Tamslo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210026
Change subject: Added column 'source' to violation table
......................................................................
Added column 'source' to violation table
Therefore adapted ResultToViolationTranslator.
Change-Id: I2ddc2f0f840350d83fe16c3a1d37baa61dcdcf2f
---
M includes/CrossCheck/Result/CrossCheckResultToViolationTranslator.php
M phpunit.xml.dist
2 files changed, 6 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataQualityExternalValidation
refs/changes/26/210026/1
diff --git
a/includes/CrossCheck/Result/CrossCheckResultToViolationTranslator.php
b/includes/CrossCheck/Result/CrossCheckResultToViolationTranslator.php
index dc53968..d155ebb 100755
--- a/includes/CrossCheck/Result/CrossCheckResultToViolationTranslator.php
+++ b/includes/CrossCheck/Result/CrossCheckResultToViolationTranslator.php
@@ -27,11 +27,12 @@
//TODO: Use real ClaimGuid and TypeEntityId
$constraintTypeEntityId =
$crossCheckResult->getDumpMetaInformation()->getSourceItemId();
$constraintId = md5(
$crossCheckResult->getDumpMetaInformation()->getImportDate()->format( 'YmdHis'
) . $constraintTypeEntityId );
+ $source = 'external-validation';
$revisionId = $this->getRevisionIdForEntity( $entityId );
$status = CrossCheckResult::STATUS_DATA_MISMATCH;
$additionalInformation = $this->setAdditionalInformationJson(
$crossCheckResult );
- $violationArray[] = new Violation( $entityId, $propertyId,
$claimGuid, $constraintId, $constraintTypeEntityId, $revisionId, $status,
$additionalInformation);
+ $violationArray[] = new Violation( $entityId, $propertyId,
$claimGuid, $constraintId, $source, $constraintTypeEntityId, $revisionId,
$status, $additionalInformation);
}
return $violationArray;
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index c15c31e..7363a75 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -19,10 +19,10 @@
</testsuites>
<filter>
<whitelist addUncoveredFilesFromWhitelist="true">
- <directory
suffix=".php">../WikidataQualityExternalValidation/api</directory>
- <directory
suffix=".php">../WikidataQualityExternalValidation/includes</directory>
- <directory
suffix=".php">../WikidataQualityExternalValidation/maintenance</directory>
- <directory
suffix=".php">../WikidataQualityExternalValidation/specials</directory>
+ <directory suffix=".php">api</directory>
+ <directory suffix=".php">includes</directory>
+ <directory suffix=".php">maintenance</directory>
+ <directory suffix=".php">specials</directory>
</whitelist>
</filter>
<logging>
--
To view, visit https://gerrit.wikimedia.org/r/210026
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ddc2f0f840350d83fe16c3a1d37baa61dcdcf2f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Tamslo <tamaraslosa...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
