jenkins-bot has submitted this change and it was merged.
Change subject: Append drawers to body so they can work in other skins
......................................................................
Append drawers to body so they can work in other skins
Let's add it to a more standard element.
Skin should use body so that animations can apply to other things
outside the viewport - for example drawers and toast.
Change-Id: I7a81e9061aac591d322d37667ab5707ea6cd1fbf
---
M javascripts/Drawer.js
M javascripts/init.js
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/Drawer.js b/javascripts/Drawer.js
index d826c49..7eeac8c 100644
--- a/javascripts/Drawer.js
+++ b/javascripts/Drawer.js
@@ -14,7 +14,7 @@
* Defines an element that the Drawer should automatically be
appended to.
* @property {String}
*/
- appendToElement: '#mw-mf-viewport',
+ appendToElement: 'body',
closeOnScroll: true,
events: $.extend( {}, Panel.prototype.events, {
click: 'stopPropagation'
diff --git a/javascripts/init.js b/javascripts/init.js
index a8e9624..2f65dbb 100644
--- a/javascripts/init.js
+++ b/javascripts/init.js
@@ -15,7 +15,7 @@
Skin = M.require( 'Skin' );
skin = new Skin( {
- el: '#mw-mf-viewport',
+ el: 'body',
tabletModules: mw.config.get( 'skin' ) === 'minerva' ? [
'tablet.scripts' ] : [],
page: getCurrentPage(),
mainMenu: new MainMenu()
--
To view, visit https://gerrit.wikimedia.org/r/203242
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a81e9061aac591d322d37667ab5707ea6cd1fbf
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
