Gilles has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174385

Change subject: Avoid undefined index warnings on $states array
......................................................................

Avoid undefined index warnings on $states array

Change-Id: Ia9e9247b10aba4838ec262f07afcab582a3c565e
---
M SpecialTimedMediaHandler.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/85/174385/1

diff --git a/SpecialTimedMediaHandler.php b/SpecialTimedMediaHandler.php
index 2192f0f..ac0968a 100644
--- a/SpecialTimedMediaHandler.php
+++ b/SpecialTimedMediaHandler.php
@@ -82,7 +82,9 @@
                                . "</h2>"
                        );
                        foreach( $allTranscodes as $key ) {
-                               if ( $states[ $state ][ $key ] ) {
+                               if ( isset( $states[ $state ] )
+                                       && isset( $states[ $state ][ $key ] )
+                                       && $states[ $state ][ $key ] ) {
                                        $out->addHTML(
                                                $states[ $state ][ $key ]
                                                . ' '

-- 
To view, visit https://gerrit.wikimedia.org/r/174385
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9e9247b10aba4838ec262f07afcab582a3c565e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Gilles <gdu...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to