Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88685


Change subject: Check whether message handle is valid in isTranslatableMessage 
method
......................................................................

Check whether message handle is valid in isTranslatableMessage method

Otherwise it throws exceeption: 'called before isValid'

Change-Id: Id4fb9c461c51338741539ed7642d25c26e20aaa5
---
M MessageGroups.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/85/88685/1

diff --git a/MessageGroups.php b/MessageGroups.php
index 06306c3..33a8d94 100644
--- a/MessageGroups.php
+++ b/MessageGroups.php
@@ -698,6 +698,10 @@
        public static function isTranslatableMessage( MessageHandle $handle ) {
                static $cache = array();
 
+               if ( !$handle->isValid() ) {
+                       return false;
+               }
+
                $group = $handle->getGroup();
                $groupId = $group->getId();
                $language = $handle->getCode();

-- 
To view, visit https://gerrit.wikimedia.org/r/88685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4fb9c461c51338741539ed7642d25c26e20aaa5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to