TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/131901

Change subject: Clear the statusbar if all no annotaitons are left
......................................................................

Clear the statusbar if all no annotaitons are left

Bug: 64758
Change-Id: Id2a26742420d03242265e537dc5404707c4bf714
---
M modules/jquery.codeEditor.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeEditor 
refs/changes/01/131901/1

diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index 52080ac..42a7979 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -417,7 +417,8 @@
                                                        closestAnnotation !== 
$message.data( 'annotation') ) {
                                                $message.data( 'annotation', 
closestAnnotation );
                                                $message.text( $.ucFirst( 
closestAnnotation.type ) + ': ' + closestAnnotation.text );
-                                       } else if ( $message.data( 'annotation' 
) !== null && ( closestAnnotation && currentLine !== closestAnnotation.row ) ) {
+                                       } else if ( $message.data( 'annotation' 
) !== null &&
+                                                       ( !closestAnnotation || 
currentLine !== closestAnnotation.row ) ) {
                                                // If we are on a different 
line without an annotation, then blank the message
                                                $message.data( 'annotation', 
null );
                                                $message.text( '' );

-- 
To view, visit https://gerrit.wikimedia.org/r/131901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2a26742420d03242265e537dc5404707c4bf714
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to