TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/192186

Change subject: ComboBox: Use combobox role
......................................................................

ComboBox: Use combobox role

This let's screenreaders know that this is actually a combobox that
when activate will present a drowdown list.

Change-Id: I788d0f35fb0a974e290141ef0079699de842a64d
---
M src/widgets/ComboBoxWidget.js
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/86/192186/1

diff --git a/src/widgets/ComboBoxWidget.js b/src/widgets/ComboBoxWidget.js
index e82b72e..770d7e8 100644
--- a/src/widgets/ComboBoxWidget.js
+++ b/src/widgets/ComboBoxWidget.js
@@ -34,6 +34,10 @@
                },
                config.input
        ) );
+       this.input.$input.eq(0).attr( {
+               role: 'combobox',
+               'aria-autocomplete': 'list'
+       } );
        this.menu = new OO.ui.TextInputMenuSelectWidget( this.input, $.extend(
                {
                        widget: this,

-- 
To view, visit https://gerrit.wikimedia.org/r/192186
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I788d0f35fb0a974e290141ef0079699de842a64d
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to