Mooeypoo has uploaded a new change for review. https://gerrit.wikimedia.org/r/69341
Change subject: Directionality fix for iframes ...................................................................... Directionality fix for iframes This will set the stage for directionality inheritance inside iframes, and fix some of the problem with the Page Settings window in RTL wikis. Bug: 49613 Change-Id: I418e669b0999552167683352acb365a4249ab9cc --- M modules/ve/ui/ve.ui.Frame.js 1 file changed, 12 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/41/69341/1 diff --git a/modules/ve/ui/ve.ui.Frame.js b/modules/ve/ui/ve.ui.Frame.js index dda0be5..0fad7e5 100644 --- a/modules/ve/ui/ve.ui.Frame.js +++ b/modules/ve/ui/ve.ui.Frame.js @@ -34,6 +34,10 @@ this.$ .addClass( 've-ui-frame' ) .attr( { 'frameborder': 0, 'scrolling': 'no' } ); + + // Set this up so the directionality is inherited inside the frame: + this.$.css('direction', $('body').css('direction')); + }; /* Inheritance */ @@ -89,17 +93,18 @@ // Initialize contents doc.open(); doc.write( - '<!doctype html>' + - '<html>' + - '<body style="padding:0;margin:0;">' + - '<div class="ve-ui-frame-content"></div>' + - '</body>' + - '</html>' - ); + '<!doctype html>' + + '<html>' + + '<body style="padding:0;margin:0;direction: ' + this.$.css( 'direction' ) + ';">' + + '<div class="ve-ui-frame-content"></div>' + + '</body>' + + '</html>' + ); doc.close(); // Import all stylesheets style.textContent = '@import "' + this.config.stylesheets.join( '";\n@import "' ) + '";'; + doc.body.appendChild( style ); // Poll for access to stylesheet content -- To view, visit https://gerrit.wikimedia.org/r/69341 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I418e669b0999552167683352acb365a4249ab9cc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Mooeypoo <mor...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits