Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/295605
Change subject: Don't abort EditFilterMergedContent hook ...................................................................... Don't abort EditFilterMergedContent hook Other extensions may want to abort the edit, too and add additional error messages. If they're called after the ConfirmEdit hook, the user usually runs into a re-submit loop. To prevent this, ConfirmEdit shouldn't abort the hook execution after adding the need of a CAPTCHA. There's also no reason to do this, so removing it. Bug: T22661 Change-Id: I4da603f84575daea545b0b9ba9555bd43b5049a3 --- M SimpleCaptcha/Captcha.php 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ConfirmEdit refs/changes/05/295605/1 diff --git a/SimpleCaptcha/Captcha.php b/SimpleCaptcha/Captcha.php index 63ed6d6..3221964 100644 --- a/SimpleCaptcha/Captcha.php +++ b/SimpleCaptcha/Captcha.php @@ -858,7 +858,6 @@ } $this->addCaptchaAPI( $status->apiHookResult ); $page->ConfirmEdit_ActivateCaptcha = true; - return $legacyMode; } return true; } -- To view, visit https://gerrit.wikimedia.org/r/295605 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4da603f84575daea545b0b9ba9555bd43b5049a3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ConfirmEdit Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits