[MediaWiki-commits] [Gerrit] Don't specify controls, because we show JS controls - change (mediawiki...TimedMediaHandler)

TheDJ (Code Review) Thu, 12 May 2016 15:22:17 -0700

TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/288528


Change subject: Don't specify controls, because we show JS controls
......................................................................

Don't specify controls, because we show JS controls

Learned something new from the spec. We don't need this attribute in
the DOM, not even for situations where user-agent does not have JS.

"If the [controls] attribute is present, or if scripting is disabled
for the media element, then the user agent should expose a user
interface to the user. This user interface should include features to
begin playback, pause playback, seek to an arbitrary position in the
content (if the content supports arbitrary seeking), change the
volume, change the display of closed captions or embedded
sign-language tracks, select different audio tracks or turn on audio
descriptions, and show the media content in manners more suitable to
the user (e.g. fullscreen video or in an independent resizable
window). Other controls may also be made available."

Change-Id: I52f339c5e000928e224c507312e45aade549b25f
---
M TimedMediaTransformOutput.php
M resources/ext.tmh.player.js
M resources/ext.tmh.player.styles.less
M tests/parserTests.txt
4 files changed, 16 insertions(+), 24 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/28/288528/1

diff --git a/TimedMediaTransformOutput.php b/TimedMediaTransformOutput.php
index 37d6658..89c52b5 100644
--- a/TimedMediaTransformOutput.php
+++ b/TimedMediaTransformOutput.php
@@ -410,10 +410,9 @@
                        'id' => self::PLAYER_ID_PREFIX . 
TimedMediaTransformOutput::$serial++,
                        // Get the correct size:
                        'poster' => $posterUrl,
+                       // We don't set controls, to prevent flash of native 
controls
+                       // In no-js mode the user-agent is required to always 
present controls
 
-                       // Note we set controls to true ( for no-js players ) 
when mwEmbed rewrites the interface
-                       // it updates the controls attribute of the embed video
-                       'controls'=> 'true',
                        // Since we will reload the item with javascript,
                        // tell browser to not load the video before
                        'preload'=>'none',
@@ -432,10 +431,6 @@
                                unset( $mediaAttr['height'] );
                                unset( $mediaAttr['poster'] );
                        }
-
-                       if ( $this->disablecontrols ) {
-                               $mediaAttr[ 'controls' ] = false;
-                       }
                } else {
                        $mediaAttr['style'] = "width:{$width}";
 
@@ -446,6 +441,8 @@
                        // MediaWiki uses the kSkin class
                        $mediaAttr['class'] = 'kskin';
 
+                       // Used by Score extension to modify the layout of the 
toolbar...
+                       // FIXME with a class
                        if ( $this->disablecontrols ) {
                                $mediaAttr[ 'data-disablecontrols' ] = 
$this->disablecontrols;
                        }
diff --git a/resources/ext.tmh.player.js b/resources/ext.tmh.player.js
index 5bab05b..f6b85c8 100755
--- a/resources/ext.tmh.player.js
+++ b/resources/ext.tmh.player.js
@@ -4,6 +4,7 @@
 
        globalConfig = {
                language: mw.config.get( 'wgUserLanguage' ),
+               controls: true,
                controlBar: {
                        liveDisplay: false,
                        volumeMenuButton: {
@@ -102,7 +103,7 @@
                                // We remove the fullscreen button
                                playerConfig = $.extend( true, {}, 
playerConfig, audioConfig );
                        }
-                       $( videoplayer ).attr( {
+                       $videoplayer.attr( {
                                /* Don't preload on pages with many videos, 
like Category pages */
                                preload: ( index < 10 ) ? 'auto' : 'metadata'
                        } ).find( 'source' ).each( function () {
diff --git a/resources/ext.tmh.player.styles.less 
b/resources/ext.tmh.player.styles.less
index b556e62..ec7da38 100644
--- a/resources/ext.tmh.player.styles.less
+++ b/resources/ext.tmh.player.styles.less
@@ -4,12 +4,6 @@
                height: 3em;
                font-size: 10px;
        }
-
-       /* We hide the native controls, before we load the custom controls  */
-       audio.video-js::-webkit-media-controls-panel,
-       video.video-js::-webkit-media-controls-panel {
-               display: none;
-       }
 }
 
 /* Make video-js behave like standard <video><audio> elements */
diff --git a/tests/parserTests.txt b/tests/parserTests.txt
index 2050125..fd596cf 100644
--- a/tests/parserTests.txt
+++ b/tests/parserTests.txt
@@ -3,10 +3,10 @@
 !! wikitext
 [[File:Video.ogv]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_1" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_1" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
 
 !! html+tidy
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_0" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local">
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_0" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local">
 <source src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30" />Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br />
 You can <a href="http://example.com/images/0/00/Video.ogv";>download the 
clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
 !!end
@@ -16,12 +16,12 @@
 !! wikitext
 [[File:Video.ogv|thumb]]
 !! html
-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><div 
id="mwe_player_4" class="PopUpMediaTransform" style="width:180px;" 
videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_5&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 controls=&quot;&quot; preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; data-framerate=&quot;30&quot;/&gt;Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.&lt;br /&gt;&#10;You can &lt;a 
href=&quot;http://example.com/images/0/00/Video.ogv&quot;&gt;download the 
clip&lt;/a&gt; or &lt;a 
href=&quot;https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download&quot;&gt;download
 a player&lt;/a&gt; to play the clip in your 
browser.&lt;/video&gt;&lt;/div&gt;"><img alt="File:Video.ogv" 
style="width:180px;height:135px" 
src="http://example.com/images/thumb/0/00/Video.ogv/180px--Video.ogv.jpg";></img><a
 href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div>  <div class="thumbcaption"><div 
class="magnify"><a href="/wiki/File:Video.ogv" class="internal" 
title="Enlarge"></a></div></div></div></div>
+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><div 
id="mwe_player_4" class="PopUpMediaTransform" style="width:180px;" 
videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_5&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; data-framerate=&quot;30&quot;/&gt;Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.&lt;br /&gt;&#10;You can &lt;a 
href=&quot;http://example.com/images/0/00/Video.ogv&quot;&gt;download the 
clip&lt;/a&gt; or &lt;a 
href=&quot;https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download&quot;&gt;download
 a player&lt;/a&gt; to play the clip in your 
browser.&lt;/video&gt;&lt;/div&gt;"><img alt="File:Video.ogv" 
style="width:180px;height:135px" 
src="http://example.com/images/thumb/0/00/Video.ogv/180px--Video.ogv.jpg";></img><a
 href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div>  <div class="thumbcaption"><div 
class="magnify"><a href="/wiki/File:Video.ogv" class="internal" 
title="Enlarge"></a></div></div></div></div>
 
 !! html+tidy
 <div class="thumb tright">
 <div class="thumbinner" style="width:182px;">
-<div id="mwe_player_2" class="PopUpMediaTransform" style="width:180px;" 
videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_3&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 controls=&quot;&quot; preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; data-framerate=&quot;30&quot;/&gt;Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.&lt;br /&gt;
+<div id="mwe_player_2" class="PopUpMediaTransform" style="width:180px;" 
videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_3&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; data-framerate=&quot;30&quot;/&gt;Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.&lt;br /&gt;
 You can &lt;a 
href=&quot;http://example.com/images/0/00/Video.ogv&quot;&gt;download the 
clip&lt;/a&gt; or &lt;a 
href=&quot;https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download&quot;&gt;download
 a player&lt;/a&gt; to play the clip in your 
browser.&lt;/video&gt;&lt;/div&gt;"><img alt="File:Video.ogv" 
style="width:180px;height:135px" 
src="http://example.com/images/thumb/0/00/Video.ogv/180px--Video.ogv.jpg"; /><a 
href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div>
 <div class="thumbcaption">
 <div class="magnify"><a href="/wiki/File:Video.ogv" class="internal" 
title="Enlarge"></a></div>
@@ -37,7 +37,7 @@
 !! html
 <ul class="gallery mw-gallery-traditional">
                <li class="gallerybox" style="width: 155px"><div style="width: 
155px">
-                       <div class="thumb" style="width: 150px;"><div 
style="margin:30px auto;"><div id="mwe_player_6" class="PopUpMediaTransform" 
style="width:120px;" videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_7&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 controls=&quot;&quot; preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; data-framerate=&quot;30&quot;/&gt;Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.&lt;br /&gt;&#10;You can &lt;a 
href=&quot;http://example.com/images/0/00/Video.ogv&quot;&gt;download the 
clip&lt;/a&gt; or &lt;a 
href=&quot;https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download&quot;&gt;download
 a player&lt;/a&gt; to play the clip in your 
browser.&lt;/video&gt;&lt;/div&gt;"><img alt="File:Video.ogv" 
style="width:120px;height:90px" 
src="http://example.com/images/thumb/0/00/Video.ogv/120px--Video.ogv.jpg";></img><a
 href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div></div></div>
+                       <div class="thumb" style="width: 150px;"><div 
style="margin:30px auto;"><div id="mwe_player_6" class="PopUpMediaTransform" 
style="width:120px;" videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_7&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; data-framerate=&quot;30&quot;/&gt;Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.&lt;br /&gt;&#10;You can &lt;a 
href=&quot;http://example.com/images/0/00/Video.ogv&quot;&gt;download the 
clip&lt;/a&gt; or &lt;a 
href=&quot;https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download&quot;&gt;download
 a player&lt;/a&gt; to play the clip in your 
browser.&lt;/video&gt;&lt;/div&gt;"><img alt="File:Video.ogv" 
style="width:120px;height:90px" 
src="http://example.com/images/thumb/0/00/Video.ogv/120px--Video.ogv.jpg";></img><a
 href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div></div></div>
                        <div class="gallerytext">
                        </div>
                </div></li>
@@ -50,7 +50,7 @@
 !! wikitext
 [[File:Video.ogv|thumbtime=1:25]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_8" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_8" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
 
 !! end
 
@@ -59,7 +59,7 @@
 !! wikitext
 [[File:Video.ogv|start=1:25]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_9" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv#t=00:00:03.366"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv#t=00:00:03.366";>download the 
clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_9" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv#t=00:00:03.366"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv#t=00:00:03.366";>download the 
clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
 
 !! end
 
@@ -68,7 +68,7 @@
 !! wikitext
 [[File:Video.ogv|start=1:25|end=1:35]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_10" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv#t=00:00:03.366,00:00:03.366"; 
type="video/ogg; codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 
× 240 (590 kbps)" data-shorttitle="Ogg source" data-width="320" 
data-height="240" data-bandwidth="590013" data-framerate="30"/>Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv#t=00:00:03.366,00:00:03.366";>download
 the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_10" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv#t=00:00:03.366,00:00:03.366"; 
type="video/ogg; codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 
× 240 (590 kbps)" data-shorttitle="Ogg source" data-width="320" 
data-height="240" data-bandwidth="590013" data-framerate="30"/>Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv#t=00:00:03.366,00:00:03.366";>download
 the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
 
 !! end
 
@@ -77,7 +77,7 @@
 !! wikitext
 [[File:Video.ogv|alt=Test]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_11" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_11" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
 
 !! end
 
@@ -86,7 +86,7 @@
 !! wikitext
 [[File:Video.ogv|link=Example]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_12" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_12" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
 
 !! end
 

-- 
To view, visit https://gerrit.wikimedia.org/r/288528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I52f339c5e000928e224c507312e45aade549b25f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't specify controls, because we show JS controls - change (mediawiki...TimedMediaHandler)

Reply via email to