Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/243167
Change subject: Ensure full error message is show when inspector is closed
......................................................................
Ensure full error message is show when inspector is closed
Applying staging doesn't emit an update event on the node, so
forcefully emit one with 'staged' equal to false, so the full
error is rendered (if present).
Logically depends on I8ebb26d4bc in core.
Bug: T114480
Change-Id: I7ba54b67982fc5b10839426cdc216e14c0e33c01
---
M modules/ve-mw/ui/inspectors/ve.ui.MWLiveExtensionInspector.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/67/243167/1
diff --git a/modules/ve-mw/ui/inspectors/ve.ui.MWLiveExtensionInspector.js
b/modules/ve-mw/ui/inspectors/ve.ui.MWLiveExtensionInspector.js
index 57450e2..8340b4c 100644
--- a/modules/ve-mw/ui/inspectors/ve.ui.MWLiveExtensionInspector.js
+++ b/modules/ve-mw/ui/inspectors/ve.ui.MWLiveExtensionInspector.js
@@ -78,6 +78,8 @@
// to the model in staging, just need to apply them.
this.updatePreview();
this.getFragment().getSurface().applyStaging();
+ // Force the selected node to re-render after staging has finished
+ this.selectedNode.emit( 'update', false );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/243167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ba54b67982fc5b10839426cdc216e14c0e33c01
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
