Ed Hoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261211
Change subject: Fix fatal error where SemanticForms accesses Cargo private
property
......................................................................
Fix fatal error where SemanticForms accesses Cargo private property
Semantic Form accessing Cargo private property yields fatal error when editing
form
class CargoFieldDescription {
...
public $mDelimiter;
was recently changed to
class CargoFieldDescription {
...
private $mDelimiter;
which causes the following error "Fatal error: Cannot access private property
CargoFieldDescription::$mDelimiter in
/www-wiki/core/extensions/SemanticForms/includes/SF_TemplateField.php on line
160"
Bug: T122522
Change-Id: Ifb02896e8ca5c58c11ce5ceed9a9a6b261c82389
---
M includes/SF_TemplateField.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms
refs/changes/11/261211/1
diff --git a/includes/SF_TemplateField.php b/includes/SF_TemplateField.php
index 2e660fb..bb778aa 100644
--- a/includes/SF_TemplateField.php
+++ b/includes/SF_TemplateField.php
@@ -157,7 +157,7 @@
$this->mFieldType = $fieldDescription->mType;
}
$this->mIsList = $fieldDescription->mIsList;
- $this->mDelimiter = $fieldDescription->mDelimiter;
+ $this->mDelimiter = $fieldDescription->getDelimiter();
$this->mPossibleValues = $fieldDescription->mAllowedValues;
}
--
To view, visit https://gerrit.wikimedia.org/r/261211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb02896e8ca5c58c11ce5ceed9a9a6b261c82389
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Ed Hoo <edward....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
