Mooeypoo has uploaded a new change for review. https://gerrit.wikimedia.org/r/195960
Change subject: Followup to Iadc6abdcc: Allow for empty text in deprecated property ...................................................................... Followup to Iadc6abdcc: Allow for empty text in deprecated property Allow for 'true' value in deprecated without guidance text. The option to have, in general, fields that necessitate text (so fields that have values of either 'false' or a string, rather thatn 'false', 'true' or a string, remains an option in the code (added a comment to specify) Change-Id: I1ec843cc443e6c33e0fc642ec7eefa012410b5a8 --- M modules/ext.templateDataGenerator.data.js 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateData refs/changes/60/195960/1 diff --git a/modules/ext.templateDataGenerator.data.js b/modules/ext.templateDataGenerator.data.js index 51da0fe..3a91a18 100644 --- a/modules/ext.templateDataGenerator.data.js +++ b/modules/ext.templateDataGenerator.data.js @@ -192,8 +192,14 @@ textValue: 'deprecatedValue' }, deprecatedValue: { - type: 'string', - changesBooleanValue: 'deprecated' + type: 'string' + // While this doesn't apply to deprecated field specifically, + // there is an option in connected properties to use + // 'changesBooleanValue:{booleanAttribute}' that + // refers to the attribute that should depend on the + // text value. This could be used if the option for boolean + // necessitates text (either there is text or the value is + // 'false', with never an option for an empty-text 'true') }, required: { type: 'boolean' -- To view, visit https://gerrit.wikimedia.org/r/195960 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ec843cc443e6c33e0fc642ec7eefa012410b5a8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TemplateData Gerrit-Branch: master Gerrit-Owner: Mooeypoo <mor...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits