jenkins-bot has submitted this change and it was merged. Change subject: Improve workflow selector on Special:Translate ......................................................................
Improve workflow selector on Special:Translate Closer to the designs. Remove unused CSS rules. Change-Id: I845ed32c7e0b8be69c66b610d765ee7e7f106f78 --- M resources/css/ext.translate.dropdownmenu.css M resources/css/ext.translate.workflowselector.css M resources/js/ext.translate.workflowselector.js 3 files changed, 16 insertions(+), 6 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/css/ext.translate.dropdownmenu.css b/resources/css/ext.translate.dropdownmenu.css index 10dc335..e2e5450 100644 --- a/resources/css/ext.translate.dropdownmenu.css +++ b/resources/css/ext.translate.dropdownmenu.css @@ -1,15 +1,13 @@ .tux-dropdown-menu { - padding-top: 2em; border: 1px solid #c9c9c9; /* @noflip */ -webkit-box-shadow: 0 3px 3px -3px rgba(0, 0, 0, 0.5); /* @noflip */ box-shadow: 0 3px 3px -3px rgba(0, 0, 0, 0.5); font-size: 14px; - margin: 0 5px; + margin: 0; list-style: none; padding: 4px; - width: 200px; z-index: 300; background: #fff; display: block; diff --git a/resources/css/ext.translate.workflowselector.css b/resources/css/ext.translate.workflowselector.css index f8ce19b..574d960 100644 --- a/resources/css/ext.translate.workflowselector.css +++ b/resources/css/ext.translate.workflowselector.css @@ -5,15 +5,20 @@ cursor: pointer; display: inline-block; padding: 2px 4px; - margin: 5px 0; + margin-top: 5px; + min-width: 150px; } .tux-workflow-status:hover { border: 1px solid #c9c9c9; } -.tux-workflow-status:after { - margin-left: 3px; +.tux-workflow-status-triangle { + float: right; +} + +.tux-workflow-status-triangle:after { + margin: 3px; border-left: 3px solid transparent; border-right: 3px solid transparent; border-top: 3px solid #555; @@ -22,6 +27,11 @@ vertical-align: middle; } +ul.tux-workflow-status-selector { + min-width: 150px; + margin-top: -1px; +} + .tux-workflow-status-selector li { color: #555555; display: block; diff --git a/resources/js/ext.translate.workflowselector.js b/resources/js/ext.translate.workflowselector.js index 4d2c002..4400528 100644 --- a/resources/js/ext.translate.workflowselector.js +++ b/resources/js/ext.translate.workflowselector.js @@ -120,6 +120,7 @@ if ( id === instance.currentState ) { $display.text( instance.getStateDisplay( data.name ) ); + $display.append( $( '<span>' ).addClass( 'tux-workflow-status-triangle' ) ); $state.addClass( 'selected' ); } @@ -132,6 +133,7 @@ state = $this.data( 'state' ).id; $display.text( mw.msg( 'translate-workflow-set-doing' ) ); + $display.append( $( '<span>' ).addClass( 'tux-workflow-status-triangle' ) ); instance.changeState( state ) .done( function () { instance.receiveState( instance.groupId, instance.language, state ); -- To view, visit https://gerrit.wikimedia.org/r/210655 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I845ed32c7e0b8be69c66b610d765ee7e7f106f78 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@kitano.nl> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits