Henning Snater has submitted this change and it was merged. Change subject: JS refactoring: Api.js ......................................................................
JS refactoring: Api.js still to do: - tests - decide how to publish response (e.g. events), see TODOs - integrate into EditableValue patchset 2: baserevid is now a parameter; removed obsolet method performApiAction; fixed whitespaces; patchset 3: fixed documentation; added missing apicall parameters; patch set 4: Extending mw.Api instead of instantiating mw.Api on each AJAX request. patch set 5: minor documentation update patch set 6: simplified and renamed queryApi/post method patch set 7: added newEntity method to API patch set 8: rebased Change-Id: Ie6ca0805517d225a4712b772c8abbeed0977c772 --- M lib/resources/wikibase.store/wikibase.Api.js 1 file changed, 122 insertions(+), 2 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/31206 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6ca0805517d225a4712b772c8abbeed0977c772 Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Jens Ohlig <jens.oh...@wikimedia.de> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
