Brion VIBBER has submitted this change and it was merged. Change subject: JavaScript maintenance ......................................................................
JavaScript maintenance This fix a few trivial Javascript lint checks which should be harmless although untested. * jshintrc comes from Mediawiki core, I have slightly tweaked it to allow alert() and multiples "var" declarations. * Fixed equalities to strict equalities. * Some double quotes have been singled out. * Missing semicolon (some of them might still be need to be added). Change-Id: I846d5a87f8761aec1d3897a35a1d12c8f85b916f --- A .jshintrc M modules/ext.svgedit.editButton.js M modules/ext.svgedit.editor.js M modules/ext.svgedit.embedapi.js M modules/ext.svgedit.formmultipart.js M modules/ext.svgedit.inline.js M modules/ext.svgedit.io.js M modules/ext.svgedit.toolbar.js 8 files changed, 86 insertions(+), 48 deletions(-) Approvals: Krinkle: Looks good to me, but someone else must approve Brion VIBBER: Verified; Looks good to me, approved Hashar: Looks good to me, but someone else must approve jenkins-bot: Checked -- To view, visit https://gerrit.wikimedia.org/r/36754 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I846d5a87f8761aec1d3897a35a1d12c8f85b916f Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/SVGEdit Gerrit-Branch: master Gerrit-Owner: Hashar <has...@free.fr> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Krinkle <ttij...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
