Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/270905
Change subject: Logging in via LoginPage#login_with is a security risk ...................................................................... Logging in via LoginPage#login_with is a security risk API should be used to log in instead. Bug: T127042 Change-Id: I63095095e2bee476fefe38f0b8ed6b6b0a9c0e5b --- D lib/mediawiki_selenium/pages/login_page.rb 1 file changed, 0 insertions(+), 27 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium refs/changes/05/270905/1 diff --git a/lib/mediawiki_selenium/pages/login_page.rb b/lib/mediawiki_selenium/pages/login_page.rb deleted file mode 100644 index 8ef1e44..0000000 --- a/lib/mediawiki_selenium/pages/login_page.rb +++ /dev/null @@ -1,27 +0,0 @@ -require 'page-object' - -class LoginPage - include PageObject - - page_url 'Special:UserLogin' - - div(:feedback, class: 'errorbox') - button(:login, id: 'wpLoginAttempt') - li(:logout, id: 'pt-logout') - text_field(:password, id: 'wpPassword1') - a(:password_strength, text: 'password strength') - a(:phishing, text: 'phishing') - text_field(:username, id: 'wpName1') - a(:username_displayed, title: /Your user page/) - - def logged_in_as_element - @browser.div(id: 'mw-content-text').p.b - end - - def login_with(username, password, wait_for_logout_element = true) - username_element.when_present.send_keys(username) - password_element.when_present.send_keys(password) - login_element.when_present.click - logout_element.when_present(10) if wait_for_logout_element - end -end -- To view, visit https://gerrit.wikimedia.org/r/270905 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I63095095e2bee476fefe38f0b8ed6b6b0a9c0e5b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/selenium Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
