jenkins-bot has submitted this change and it was merged.

Change subject: MWLinkTargetInputWidget: Add styles for invalid link titles
......................................................................


MWLinkTargetInputWidget: Add styles for invalid link titles

This color is chosen because it is already present as a warning color in
other mediawiki elements like remove button in Link Inspector. A font
weight of bold is also given to make it more prominent.

Things done for this commit:
* A new CSS file 've.ui.MWLinkTargetInputWidget.css' is added.
* Warning text style is added to the class
  '.ve-ui-mwLinkTargetInputWidget-warning' in this file.
* The CSS file is included in the style resources in the
  file 'VisualEditor.php'.

Tested in latest stable firefox, chrome in Ubuntu 14.04.

Bug: 62761
Change-Id: I89e96e0444f8505123f3c653cf2dd6b74fc83623
---
M VisualEditor.php
A modules/ve-mw/ui/styles/widgets/ve.ui.MWLinkTargetInputWidget.css
2 files changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/VisualEditor.php b/VisualEditor.php
index 7a3f51f..d3df702 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -901,6 +901,9 @@
 
                        
'modules/ve-mw/ui/tools/ve.ui.MWLinkNodeInspectorTool.js',
                ),
+               'styles' => array(
+                       
'modules/ve-mw/ui/styles/widgets/ve.ui.MWLinkTargetInputWidget.css'
+               ),
                'skinStyles' => array(
                        'default' => array(
                                
'modules/ve-mw/ui/themes/apex/ve.ui.MWLinkTargetInputWidget.css'
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWLinkTargetInputWidget.css 
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWLinkTargetInputWidget.css
new file mode 100644
index 0000000..5d6a8c6
--- /dev/null
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWLinkTargetInputWidget.css
@@ -0,0 +1,13 @@
+/*!
+ * VisualEditor MediaWiki UserInterface MWLinkTargetInputWidget styles.
+ *
+ * @copyright 2011-2014 VisualEditor Team and others; see AUTHORS.txt
+ * @license The MIT License (MIT); see LICENSE.txt
+ */
+
+ /* Warning text for invalid titles (bug 62761) */
+
+.ve-ui-mwLinkTargetInputWidget-warning {
+       color: #d45353;
+       font-weight: bold;
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/150297
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89e96e0444f8505123f3c653cf2dd6b74fc83623
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Palerdot <paler...@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Robmoen <rm...@wikimedia.org>
Gerrit-Reviewer: Ryasmeen <ryasm...@wikimedia.org>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to