jenkins-bot has submitted this change and it was merged. Change subject: MWLinkTargetInputWidget: Check title is valid in MediaWiki ......................................................................
MWLinkTargetInputWidget: Check title is valid in MediaWiki Bug: T86709 Change-Id: Ia399d3e8847d520b5d57baa302de8197fdea0787 --- M modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js b/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js index bbaef8e..cbce985 100644 --- a/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js +++ b/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js @@ -90,7 +90,7 @@ valid = this.annotation.getAttribute( 'href' ) .match( /(^|\s)((https?:\/\/)?[\w-]+(\.[\w-]+)+\.?(:\d+)?(\/\S*)?)/gi ); } else { - valid = !!this.getValue(); + valid = !!mw.Title.newFromText( this.getValue() ); } return $.Deferred().resolve( valid ).promise(); }; -- To view, visit https://gerrit.wikimedia.org/r/185381 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia399d3e8847d520b5d57baa302de8197fdea0787 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Alex Monk <kren...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits