Brion VIBBER has submitted this change and it was merged. Change subject: Make python files almost PEP8 compliant ......................................................................
Make python files almost PEP8 compliant Except the 80 char line length limit. Boo to that! Also add flake8 config file. Should setup jenkins job soon. Change-Id: If49596b9d02c3c631c95f1f6c7cd7b8efca2d7f6 --- M scripts/convert-icons.py M scripts/generate_wiki_languages.py A scripts/tox.ini 3 files changed, 4 insertions(+), 2 deletions(-) Approvals: Brion VIBBER: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/convert-icons.py b/scripts/convert-icons.py index ad65918..4eeffc7 100644 --- a/scripts/convert-icons.py +++ b/scripts/convert-icons.py @@ -39,7 +39,7 @@ self._do_flop(density, self._do_export(density, svg)) print u"\u2713 %s" % os.path.basename(svg) - + if __name__ == "__main__": paths = glob(os.path.join(os.path.dirname(__file__), "../icon-svgs/*")) for path in paths: diff --git a/scripts/generate_wiki_languages.py b/scripts/generate_wiki_languages.py index 22fcfe6..86a97f1 100644 --- a/scripts/generate_wiki_languages.py +++ b/scripts/generate_wiki_languages.py @@ -17,7 +17,7 @@ for row in data: if is_first: is_first = False - continue # skip headers! + continue # skip headers! if row[2] == 'got': # 'got' is Gothic Runes, which lie ouotside the BMP # Android segfaults on these. So let's ignore those. diff --git a/scripts/tox.ini b/scripts/tox.ini new file mode 100644 index 0000000..aa079ec --- /dev/null +++ b/scripts/tox.ini @@ -0,0 +1,2 @@ +[flake8] +max-line-length=120 -- To view, visit https://gerrit.wikimedia.org/r/124746 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If49596b9d02c3c631c95f1f6c7cd7b8efca2d7f6 Gerrit-PatchSet: 2 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits