Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/187874

Change subject: Make sure all PHP files are available from the host machine
......................................................................

Make sure all PHP files are available from the host machine

Copy PHP files from the docroot to a subdirectory of /vagrant.
(Simply placing the docroot there would run into file permission
problems as vagrant does not have root access to NFS shares.)

This is important for debuggers which can get confused by remote
files not present on the host machine.

Bug: T88149
Change-Id: I7058f60017226ad2a73791bee7fa1b37013630a9
---
M puppet/modules/apache/manifests/init.pp
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/74/187874/1

diff --git a/puppet/modules/apache/manifests/init.pp 
b/puppet/modules/apache/manifests/init.pp
index 3c9569b..24f5e39 100644
--- a/puppet/modules/apache/manifests/init.pp
+++ b/puppet/modules/apache/manifests/init.pp
@@ -81,6 +81,14 @@
         }
     }
 
+    # make sure all PHP files are available from the host machine so they can 
be debugged
+    file { '/vagrant/docroot':
+        ensure             => present,
+        source             => $docroot,
+        source_permissions => ignore,
+        recurse            => remote,
+    }
+
     Apache::Env <| |> -> Apache::Mod_conf <| |> -> Apache::Conf <| |>
     Apache::Site <| |> -> Apache::Site_conf <| |>
 

-- 
To view, visit https://gerrit.wikimedia.org/r/187874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7058f60017226ad2a73791bee7fa1b37013630a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to