Platonides has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70059
Change subject: Make take non-recursive by default.
......................................................................
Make take non-recursive by default.
Do not take folders unless --recursive was specified.
Change-Id: Iad953b30f4b9306af10c50d4336d71e850a356b2
---
M src/take.cc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/toollabs
refs/changes/59/70059/1
diff --git a/src/take.cc b/src/take.cc
index f695c13..08dedc0 100755
--- a/src/take.cc
+++ b/src/take.cc
@@ -136,6 +136,9 @@
if(!found)
return refuse(path, "You need to share a group with the file");
+ if (!recursive && S_ISDIR(sfile.st_mode))
+ return refuse(path, "Is a directory, use -r to take
recursively.");
+
// everything checks out; do it. Do it! Doooo it!
if(fchown(file, getuid(), -1))
return error(path);
--
To view, visit https://gerrit.wikimedia.org/r/70059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad953b30f4b9306af10c50d4336d71e850a356b2
Gerrit-PatchSet: 1
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: Platonides <platoni...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
