Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/149635

Change subject: Make the overlay used by the language dialog global
......................................................................

Make the overlay used by the language dialog global

Otherwise it doesn't shield the personal toolbar.

Bug: 68486
Change-Id: Ia99d368a41ab581a2bd4e3e39d6fc6efe5e6ffb4
---
M modules/ve/ui/widgets/ve.ui.LanguageInputWidget.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/35/149635/1

diff --git a/modules/ve/ui/widgets/ve.ui.LanguageInputWidget.js 
b/modules/ve/ui/widgets/ve.ui.LanguageInputWidget.js
index 1527e33..c23c739 100644
--- a/modules/ve/ui/widgets/ve.ui.LanguageInputWidget.js
+++ b/modules/ve/ui/widgets/ve.ui.LanguageInputWidget.js
@@ -75,7 +75,9 @@
                        icon: 'text-dir-ltr'
                } )
        ] );
-       this.overlay.$element.append( this.dialogs.$element );
+       this.overlay.$element
+               .addClass( 've-ui-surface-globalOverlay' )
+               .append( this.dialogs.$element );
        $( 'body' ).append( this.overlay.$element );
        // TODO: Rethink the layout, maybe integrate the change button into the 
language field
        // TODO: Consider using getAutonym to display a nicer language name 
label somewhere

-- 
To view, visit https://gerrit.wikimedia.org/r/149635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia99d368a41ab581a2bd4e3e39d6fc6efe5e6ffb4
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to