Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/117857
Change subject: Moved "I am at a random page" step to the mediawiki_selenium
Ruby gem
......................................................................
Moved "I am at a random page" step to the mediawiki_selenium Ruby gem
Bug: 62479
Change-Id: Ieadc4737e4fb4e295f9e5289392a32b8d793e4ab
---
M tests/browser/Gemfile.lock
M tests/browser/features/no_javascript_site.feature
M tests/browser/features/pageactions.feature
M tests/browser/features/step_definitions/common_steps.rb
4 files changed, 5 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/57/117857/1
diff --git a/tests/browser/Gemfile.lock b/tests/browser/Gemfile.lock
index 5f91754..6d2f0e2 100644
--- a/tests/browser/Gemfile.lock
+++ b/tests/browser/Gemfile.lock
@@ -15,7 +15,7 @@
faker (>= 1.1.2)
yml_reader (>= 0.2)
diff-lcs (1.2.5)
- faker (1.2.0)
+ faker (1.3.0)
i18n (~> 0.5)
ffi (1.9.3)
gherkin (2.12.2)
@@ -23,7 +23,7 @@
headless (1.0.1)
i18n (0.6.9)
json (1.8.1)
- mediawiki_selenium (0.2.9)
+ mediawiki_selenium (0.2.10)
cucumber (~> 1.3, >= 1.3.10)
headless (~> 1.0, >= 1.0.1)
json (~> 1.8, >= 1.8.1)
diff --git a/tests/browser/features/no_javascript_site.feature
b/tests/browser/features/no_javascript_site.feature
index a56c226..3b8f745 100644
--- a/tests/browser/features/no_javascript_site.feature
+++ b/tests/browser/features/no_javascript_site.feature
@@ -6,7 +6,7 @@
Scenario: Able to search in basic non-JavaScript site
Given I am using user agent "Opera/9.80 (J2ME/MIDP; Opera Mini/9.80 (S60;
SymbOS; Opera Mobi/23.348; U; en) Presto/2.5.25 Version/10.54"
- When I go to random page
+ When I am at a random page
Then I see the watch star
And I see the search button
# FIXME: Check that the edit button is invisible
@@ -14,7 +14,7 @@
Scenario: Able to access left navigation in basic non-JavaScript site
Given I am using user agent "Opera/9.80 (J2ME/MIDP; Opera Mini/9.80 (S60;
SymbOS; Opera Mobi/23.348; U; en) Presto/2.5.25 Version/10.54"
- When I go to random page
+ When I am at a random page
And I click on the main navigation button
Then I see a link to "Home" in the main navigation menu
And I see a link to "Random" in the main navigation menu
diff --git a/tests/browser/features/pageactions.feature
b/tests/browser/features/pageactions.feature
index 03f2577..89b1225 100644
--- a/tests/browser/features/pageactions.feature
+++ b/tests/browser/features/pageactions.feature
@@ -2,7 +2,7 @@
Feature: Page actions menu when anonymous
Background:
- Given I go to random page
+ Given I am at a random page
Scenario: Receive notification message - Edit Icon
When I click the edit icon holder
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index 734b8d7..082ef6b 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -87,10 +87,6 @@
# nothing to do here, user in not logged in by default
end
-When /^I go to random page$/ do
- visit(RandomPage)
-end
-
Given(/^I am on the "(.+)" page$/) do |article|
visit(ArticlePage, :using_params => {:article_name => article})
end
--
To view, visit https://gerrit.wikimedia.org/r/117857
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieadc4737e4fb4e295f9e5289392a32b8d793e4ab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
