Ori.livneh has uploaded a new change for review. Change subject: Re-architect PEF ahead of redeployment ......................................................................
Re-architect PEF ahead of redeployment 1) Auto-register handlers. Evil as PHP is evil. I will ferociously defend my choice to dabble in the dark arts. 2) Use MakeGlobalVariablesScript rather than ResourceLoaderGetConfigVars for mutable values. From [[mw:Manual:Hooks/ResourceLoaderGetConfigVars]]: "Use this to export static configuration variables to JavaScript. Things that depend on the current page / request state must be added through MakeGlobalVariablesScript instead." This gets us reliable JS vars! 3) Use cookies to detect post-edit state rather than URL parameters, now that Musth-season is over. 4) Integrate Munaf's PEF2 changes. 5) Integrate a couple of your fixups. I've made a mess of the git history, as usual. Also postEditFeedback.js is still a mess. I'm going to clean it up. Change-Id: Idce324d3e19142be3766e7145f1107f8156bf531 --- M Experiments.hooks.php M Experiments.php M css/postEditFeedback.css M experiments/communityClicks.js M experiments/newTrack.js M experiments/postEditFeedback.js M lib/e3.js M lib/murmur3.js M lib/sample.js M lib/track.js M test/tests.js 11 files changed, 418 insertions(+), 278 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/E3Experiments refs/changes/77/22177/1 -- To view, visit https://gerrit.wikimedia.org/r/22177 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idce324d3e19142be3766e7145f1107f8156bf531 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Ori.livneh <o...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
