Jdlrobson has submitted this change and it was merged.
Change subject: Regression: Fix full screen navigation (when JS is disabled)
......................................................................
Regression: Fix full screen navigation (when JS is disabled)
Change-Id: I865bb1dfa8422b0d7a9d25e98e510ae949f0aa9d
---
M less/common/mf-navigation.less
M stylesheets/common/mf-navigation.css
2 files changed, 7 insertions(+), 23 deletions(-)
Approvals:
Jdlrobson: Verified; Looks good to me, approved
diff --git a/less/common/mf-navigation.less b/less/common/mf-navigation.less
index 1f2d452..e729c75 100644
--- a/less/common/mf-navigation.less
+++ b/less/common/mf-navigation.less
@@ -102,12 +102,13 @@
&.navigationFullScreen {
#mw-mf-page-left {
- width: 100%;
- right: 0;
+ // !important needed to override rules set by @media
min-width: 700px
+ width: 100% !important;
+ right: 0 !important;
}
#mw-mf-page-center {
- left: 100%;
+ display: none;
}
}
}
@@ -492,16 +493,6 @@
right: 0 !important;
width: 80%;
overflow: auto;
- }
- }
-
- .navigationFullScreen .beta {
- #mw-mf-page-left {
- width: 100%;
- right: 0%;
- }
- #mw-mf-page-center {
- display: none;
}
}
diff --git a/stylesheets/common/mf-navigation.css
b/stylesheets/common/mf-navigation.css
index bc263cb..57e9396 100644
--- a/stylesheets/common/mf-navigation.css
+++ b/stylesheets/common/mf-navigation.css
@@ -205,11 +205,11 @@
overflow-x: hidden;
}
.navigationEnabled.navigationFullScreen #mw-mf-page-left {
- width: 100%;
- right: 0;
+ width: 100% !important;
+ right: 0 !important;
}
.navigationEnabled.navigationFullScreen #mw-mf-page-center {
- left: 100%;
+ display: none;
}
.navigationEnabled #mw-mf-page-left {
display: block;
@@ -544,13 +544,6 @@
right: 0 !important;
width: 80%;
overflow: auto;
- }
- .navigationFullScreen .beta #mw-mf-page-left {
- width: 100%;
- right: 0%;
- }
- .navigationFullScreen .beta #mw-mf-page-center {
- display: none;
}
.beta.full-screen-search #mw-mf-page-left {
display: block !important;
--
To view, visit https://gerrit.wikimedia.org/r/51620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I865bb1dfa8422b0d7a9d25e98e510ae949f0aa9d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
