Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/237500
Change subject: Remove mobile.experiments dependency
......................................................................
Remove mobile.experiments dependency
Rationale:
- Removed mobile.experiments from mobile frontend in favor of
mediawiki.experiments
- Removed bucketing work in init.js as no experiment is currently
defined
Bug: 1628014
Change-Id: I83f4eec2691d40b56db28dd69d8453109d86ae31
---
M extension.json
M resources/ext.gather.init/init.js
2 files changed, 1 insertion(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather
refs/changes/00/237500/1
diff --git a/extension.json b/extension.json
index a2d069c..28eec93 100644
--- a/extension.json
+++ b/extension.json
@@ -388,7 +388,6 @@
],
"dependencies": [
"ext.gather.menu.icon",
- "mobile.experiments",
"mobile.watchstar",
"ext.gather.watchstar"
],
diff --git a/resources/ext.gather.init/init.js
b/resources/ext.gather.init/init.js
index ad04728..c55d6a1 100644
--- a/resources/ext.gather.init/init.js
+++ b/resources/ext.gather.init/init.js
@@ -2,7 +2,6 @@
( function ( M, $ ) {
var $star, watchstar, pageActionPointer, actionOverlay,
- bucket, useGatherStar,
CollectionsWatchstar = M.require(
'ext.gather.watchstar/CollectionsWatchstar' ),
Watchstar = M.require( 'mobile.watchstar/Watchstar' ),
PageActionOverlay = M.require(
'mobile.contentOverlays/PointerOverlay' ),
@@ -12,8 +11,8 @@
settingOverlayWasDismissed = 'gather-has-dismissed-tutorial',
mainMenuPointerDismissed = 'gather-has-dismissed-mainmenu',
user = M.require( 'user' ),
- experiments = M.require( 'experiments' ),
context = M.require( 'context' ),
+ useGatherStar = context.isBetaGroupMember(),
skin = M.require( 'skin' ),
mainMenu = M.require( 'mainMenu' ),
Page = M.require( 'Page' ),
@@ -167,14 +166,6 @@
}
}
} );
- }
-
- try {
- bucket = experiments.getBucket( 'gather' );
- useGatherStar = context.isBetaGroupMember() || bucket === 'A';
- } catch ( e ) {
- // experiment hasn't been defined. Only enable in beta.
- useGatherStar = context.isBetaGroupMember();
}
// Only init when current page is an article
--
To view, visit https://gerrit.wikimedia.org/r/237500
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83f4eec2691d40b56db28dd69d8453109d86ae31
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Robmoen <rm...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
