Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187963
Change subject: Remove overflow:hidden for headings
......................................................................
Remove overflow:hidden for headings
In 140a3b84cc8fea6861ca70b8451d399de2149d3d
h1, h2, h3, h4, h5, h6 { overflow: hidden }
was added.
overflow:hidden blocks T18691.
overflow:hidden was added to prevent overflowing of the border
bottom of h1 and h2 into floating transparent objects.
This patch generates the border bottom by a pseudo element with
overflow:hidden.
Bug: T88220
Change-Id: Ic4d3aa077eb5e6f9d760137ccf4d7e36d243a053
---
M resources/src/mediawiki.legacy/oldshared.css
M resources/src/mediawiki.skinning/content.css
M resources/src/mediawiki.skinning/elements.css
3 files changed, 21 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/63/187963/1
diff --git a/resources/src/mediawiki.legacy/oldshared.css
b/resources/src/mediawiki.legacy/oldshared.css
index c2bd5a7..51b9136 100644
--- a/resources/src/mediawiki.legacy/oldshared.css
+++ b/resources/src/mediawiki.legacy/oldshared.css
@@ -194,12 +194,17 @@
#toc h2,
.toc h2 {
display: inline;
- border: none;
padding: 0;
font-size: 100%;
font-weight: bold;
}
+/* Remove border under the header */
+#toc h2:after,
+.toc h2:after {
+ display: none;
+}
+
#toc ul,
.toc ul {
list-style-type: none;
diff --git a/resources/src/mediawiki.skinning/content.css
b/resources/src/mediawiki.skinning/content.css
index 51cb8d0..22956ee 100644
--- a/resources/src/mediawiki.skinning/content.css
+++ b/resources/src/mediawiki.skinning/content.css
@@ -55,12 +55,17 @@
#toc h2,
.toc h2 {
display: inline;
- border: none;
padding: 0;
font-size: 100%;
font-weight: bold;
}
+/* Remove border under the header */
+#toc h2:after,
+.toc h2:after {
+ display: none;
+}
+
#toc #toctitle,
.toc #toctitle,
#toc .toctitle,
diff --git a/resources/src/mediawiki.skinning/elements.css
b/resources/src/mediawiki.skinning/elements.css
index 11962f8..3848736 100644
--- a/resources/src/mediawiki.skinning/elements.css
+++ b/resources/src/mediawiki.skinning/elements.css
@@ -89,10 +89,8 @@
background: none;
font-weight: normal;
margin: 0;
- overflow: hidden;
padding-top: .5em;
padding-bottom: .17em;
- border-bottom: 1px solid #aaa;
}
h1 {
@@ -107,7 +105,6 @@
h4,
h5,
h6 {
- border-bottom: none;
font-weight: bold;
}
@@ -139,6 +136,15 @@
margin-bottom: .3em;
}
+/* Line under h1 and h2 without overlapping with floating objects T88220 */
+h1:after,
+h2:after {
+ border-bottom: 1px solid #aaa;
+ content: "";
+ display: block;
+ overflow: hidden;
+}
+
p {
margin: .4em 0 .5em 0;
line-height: 1.5em;
--
To view, visit https://gerrit.wikimedia.org/r/187963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4d3aa077eb5e6f9d760137ccf4d7e36d243a053
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
