Krinkle has submitted this change and it was merged.
Change subject: Remove the "Quickbar" feature and all things related to it
......................................................................
Remove the "Quickbar" feature and all things related to it
"Quickbar" was a feature of the Standard and CologneBlue skins that
allowed the sidebar to be displayed on left or right side of the page,
floated or fixed, and hidden on diff pages.
Standard was removed (Ia6d73c2d), and CologneBlue doesn't support this
anymore (bug 41246), so all things quickbar can now be safely removed.
* Removed user prefs option + interface
* Removed related messages
* Removed code for this in SkinLegacy
* Removed dead code in DifferenceEngine and Language
Change-Id: I5e6f7d48d6904a052a3a11547d3ebe6161463018
---
M RELEASE-NOTES-1.21
M includes/DefaultSettings.php
M includes/Preferences.php
M includes/SkinLegacy.php
M includes/diff/DifferenceEngine.php
M languages/Language.php
M languages/messages/MessagesEn.php
M languages/messages/MessagesQqq.php
M maintenance/language/messages.inc
9 files changed, 5 insertions(+), 103 deletions(-)
Approvals:
Krinkle: Verified; Looks good to me, approved
diff --git a/RELEASE-NOTES-1.21 b/RELEASE-NOTES-1.21
index 1824910..25401dc 100644
--- a/RELEASE-NOTES-1.21
+++ b/RELEASE-NOTES-1.21
@@ -328,7 +328,7 @@
were using it, you have to either copy it to your extension, or install the
Vector extension (and possibly disable its features using config settings if
you don't want them).
-* Experimental IBM DB2 support was removed due to lack of interest and
maintainership
+* Experimental IBM DB2 support was removed due to lack of interest and
maintainership.
* BREAKING CHANGE: Filenames of maintenance scripts were standardized into
lowerCamelCase format, and made more explicit:
- clear_stats.php -> clearCacheStats.php
@@ -344,7 +344,7 @@
- ShowStats -> ShowSiteStats.
* BREAKING CHANGE: (bug 38244) Removed the mediawiki.api.titleblacklist module
and moved it to the TitleBlacklist extension.
-* The Special:ActiveUsers special page was removed
+* The Special:ActiveUsers special page was removed.
* BREAKING CHANGE: Implementation of MediaWiki's JS and JSON value encoding
has changed:
** MediaWiki no longer supports PHP installations in which the native JSON
@@ -354,11 +354,13 @@
** The sets of characters escaped by default, along with the precise escape
sequences used, have changed (except for the Xml::escapeJsString()
function, which is now deprecated).
-* BREAKING CHANGE: The Services_JSON class has been removed; if necessary,
+* BREAKING CHANGE: The Services_JSON class has been removed. If necessary,
be sure to upgrade affected extensions at the same time (e.g. Collection).
* Calling Linker methods using a skin will now output deprecation warnings.
* Pages with a returnto (such as the page when you login or logout), no
longer have a rel="next" link tag.
+* The Quickbar feature of the legacy skin model and the last remnants of it
+ throughout the code base have been removed.
== Compatibility ==
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 5f7eb65..d660f50 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -3672,7 +3672,6 @@
'numberheadings' => 0,
'previewonfirst' => 0,
'previewontop' => 1,
- 'quickbar' => 5,
'rcdays' => 7,
'rclimit' => 50,
'rememberpassword' => 0,
diff --git a/includes/Preferences.php b/includes/Preferences.php
index 56dba05..8edf60a 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -546,18 +546,6 @@
'section' => 'rendering/skin',
);
}
-
- $selectedSkin = $user->getOption( 'skin' );
- if ( in_array( $selectedSkin, array( 'cologneblue', 'standard'
) ) ) {
- $settings = array_flip(
$context->getLanguage()->getQuickbarSettings() );
-
- $defaultPreferences['quickbar'] = array(
- 'type' => 'radio',
- 'options' => $settings,
- 'section' => 'rendering/skin',
- 'label-message' => 'qbsettings',
- );
- }
}
/**
diff --git a/includes/SkinLegacy.php b/includes/SkinLegacy.php
index b17abc2..9d657f7 100644
--- a/includes/SkinLegacy.php
+++ b/includes/SkinLegacy.php
@@ -36,46 +36,6 @@
public function commonPrintStylesheet() {
return true;
}
-
- /**
- * This was for the old skins and for users with 640x480 screen.
- * Please note old skins are still used and might prove useful for
- * users having old computers or visually impaired.
- */
- var $mSuppressQuickbar = false;
-
- /**
- * Suppress the quickbar from the output, only for skin supporting
- * the quickbar
- */
- public function suppressQuickbar() {
- $this->mSuppressQuickbar = true;
- }
-
- /**
- * Return whether the quickbar should be suppressed from the output
- *
- * @return Boolean
- */
- public function isQuickbarSuppressed() {
- return $this->mSuppressQuickbar;
- }
-
- function qbSetting() {
- global $wgUser;
- if ( $this->isQuickbarSuppressed() ) {
- return 0;
- }
- $q = $wgUser->getOption( 'quickbar', 0 );
- if( $q == 5 ) {
- # 5 is the default, which chooses the setting
- # depending on the directionality of your interface
language
- global $wgLang;
- return $wgLang->isRTL() ? 2 : 1;
- }
- return $q;
- }
-
}
class LegacyTemplate extends BaseTemplate {
diff --git a/includes/diff/DifferenceEngine.php
b/includes/diff/DifferenceEngine.php
index d44c050..d03a5be 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -279,11 +279,6 @@
} else {
wfRunHooks( 'DiffViewHeader', array( $this,
$this->mOldRev, $this->mNewRev ) );
- $sk = $this->getSkin();
- if ( method_exists( $sk, 'suppressQuickbar' ) ) {
- $sk->suppressQuickbar();
- }
-
if ( $this->mNewPage->equals( $this->mOldPage ) ) {
$out->setPageTitle( $this->msg(
'difference-title', $this->mNewPage->getPrefixedText() ) );
$samePage = true;
diff --git a/languages/Language.php b/languages/Language.php
index 57d456a..dd8a314 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -745,20 +745,6 @@
/**
* @return array
*/
- function getQuickbarSettings() {
- return array(
- $this->getMessage( 'qbsettings-none' ),
- $this->getMessage( 'qbsettings-fixedleft' ),
- $this->getMessage( 'qbsettings-fixedright' ),
- $this->getMessage( 'qbsettings-floatingleft' ),
- $this->getMessage( 'qbsettings-floatingright' ),
- $this->getMessage( 'qbsettings-directionality' )
- );
- }
-
- /**
- * @return array
- */
function getDatePreferences() {
return self::$dataCache->getItem( $this->mCode,
'datePreferences' );
}
diff --git a/languages/messages/MessagesEn.php
b/languages/messages/MessagesEn.php
index 8365dcb..c5dba69 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -1805,15 +1805,6 @@
# OpenSearch description
'opensearch-desc' => '{{SITENAME}} ({{CONTENTLANGUAGE}})', # do not translate
or duplicate this message to other languages
-# Quickbar
-'qbsettings' => 'Quickbar',
-'qbsettings-none' => 'None',
-'qbsettings-fixedleft' => 'Fixed left',
-'qbsettings-fixedright' => 'Fixed right',
-'qbsettings-floatingleft' => 'Floating left',
-'qbsettings-floatingright' => 'Floating right',
-'qbsettings-directionality' => 'Fixed, depending on the script directionality
of your language',
-
# Preferences page
'preferences' => 'Preferences',
'preferences-summary' => '', # do not translate or duplicate this
message to other languages
diff --git a/languages/messages/MessagesQqq.php
b/languages/messages/MessagesQqq.php
index eea11fb..725d911 100644
--- a/languages/messages/MessagesQqq.php
+++ b/languages/messages/MessagesQqq.php
@@ -2332,15 +2332,6 @@
Shown on [[Special:Search]] when the internal search is disabled.',
-# Quickbar
-'qbsettings' => 'The title of the section in [[Special:Preferences]], only
shown when using the skins "Standard/Classic" or "Cologne Blue". The quicbar is
the same as the sidebar.',
-'qbsettings-none' => '{{Identical|None}}',
-'qbsettings-fixedleft' => 'Position of the quickbar (sidebar). Used in the
preferences.',
-'qbsettings-fixedright' => 'Position of the quickbar (sidebar). Used in the
preferences.',
-'qbsettings-floatingleft' => 'Position of the quickbar (sidebar). Used in the
preferences.',
-'qbsettings-floatingright' => 'Position of the quickbar (sidebar). Used in the
preferences.',
-'qbsettings-directionality' => '"Fixed", as in the position "fixed left or
right". For left-to-right languages, the quickbar will be positioned at the
left, for right-to-left languages at the right.',
-
# Preferences page
'preferences' => 'Title of the [[Special:Preferences]] page.
{{Identical|Preferences}}',
diff --git a/maintenance/language/messages.inc
b/maintenance/language/messages.inc
index 8361b1b..33628b6 100644
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -947,15 +947,6 @@
'opensearch' => array(
'opensearch-desc',
),
- 'quickbar' => array(
- 'qbsettings',
- 'qbsettings-none',
- 'qbsettings-fixedleft',
- 'qbsettings-fixedright',
- 'qbsettings-floatingleft',
- 'qbsettings-floatingright',
- 'qbsettings-directionality',
- ),
'preferences' => array(
'preferences',
'preferences-summary',
@@ -3878,7 +3869,6 @@
'diffs' => 'Diffs',
'search' => 'Search results',
'opensearch' => 'OpenSearch description',
- 'quickbar' => 'Quickbar',
'preferences' => 'Preferences page',
'preferences-email' => 'User preference: email validation using
jQuery',
'userrights' => 'User rights',
--
To view, visit https://gerrit.wikimedia.org/r/57846
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e6f7d48d6904a052a3a11547d3ebe6161463018
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <matma....@gmail.com>
Gerrit-Reviewer: Daniel Friesen <dan...@nadir-seen-fire.com>
Gerrit-Reviewer: Demon <ch...@wikimedia.org>
Gerrit-Reviewer: Krinkle <ttij...@wikimedia.org>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
