jenkins-bot has submitted this change and it was merged. Change subject: Rename namespace (i18n -> Localizer) for ExceptionLocalizer ......................................................................
Rename namespace (i18n -> Localizer) for ExceptionLocalizer more inline with php naming conventions, and makes it easier to have repo-specific stuff in Wikibase/Repo/Localizer. Change-Id: Ic0b7916b900ce747b166e49a8a40ab3f9acd098d --- R lib/includes/Localizer/ExceptionLocalizer.php R lib/includes/Localizer/MessageParameterFormatter.php R lib/includes/Localizer/WikibaseExceptionLocalizer.php R lib/tests/phpunit/Localizer/MessageParameterFormatterTest.php R lib/tests/phpunit/Localizer/WikibaseExceptionLocalizerTest.php M repo/includes/WikibaseRepo.php M repo/includes/api/ApiErrorReporter.php M repo/includes/api/ApiWikibase.php M repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php 9 files changed, 14 insertions(+), 13 deletions(-) Approvals: WikidataJenkins: Verified Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/lib/includes/i18n/ExceptionLocalizer.php b/lib/includes/Localizer/ExceptionLocalizer.php similarity index 96% rename from lib/includes/i18n/ExceptionLocalizer.php rename to lib/includes/Localizer/ExceptionLocalizer.php index d970110..fdacaa7 100644 --- a/lib/includes/i18n/ExceptionLocalizer.php +++ b/lib/includes/Localizer/ExceptionLocalizer.php @@ -1,6 +1,6 @@ <?php -namespace Wikibase\i18n; +namespace Wikibase\Lib\Localizer; use Exception; use InvalidArgumentException; diff --git a/lib/includes/i18n/MessageParameterFormatter.php b/lib/includes/Localizer/MessageParameterFormatter.php similarity index 98% rename from lib/includes/i18n/MessageParameterFormatter.php rename to lib/includes/Localizer/MessageParameterFormatter.php index bdff3df..26c5e0f 100644 --- a/lib/includes/i18n/MessageParameterFormatter.php +++ b/lib/includes/Localizer/MessageParameterFormatter.php @@ -1,6 +1,6 @@ <?php -namespace Wikibase\i18n; +namespace Wikibase\Lib\Localizer; use DataValues\DataValue; use Language; diff --git a/lib/includes/i18n/WikibaseExceptionLocalizer.php b/lib/includes/Localizer/WikibaseExceptionLocalizer.php similarity index 98% rename from lib/includes/i18n/WikibaseExceptionLocalizer.php rename to lib/includes/Localizer/WikibaseExceptionLocalizer.php index 8324292..f04d232 100644 --- a/lib/includes/i18n/WikibaseExceptionLocalizer.php +++ b/lib/includes/Localizer/WikibaseExceptionLocalizer.php @@ -1,6 +1,6 @@ <?php -namespace Wikibase\i18n; +namespace Wikibase\Lib\Localizer; use Exception; use Message; diff --git a/lib/tests/phpunit/i18n/MessageParameterFormatterTest.php b/lib/tests/phpunit/Localizer/MessageParameterFormatterTest.php similarity index 95% rename from lib/tests/phpunit/i18n/MessageParameterFormatterTest.php rename to lib/tests/phpunit/Localizer/MessageParameterFormatterTest.php index e783338..230576c 100644 --- a/lib/tests/phpunit/i18n/MessageParameterFormatterTest.php +++ b/lib/tests/phpunit/Localizer/MessageParameterFormatterTest.php @@ -1,6 +1,7 @@ <?php namespace Wikibase\Test; + use DataValues\DataValue; use DataValues\DecimalValue; use Language; @@ -12,11 +13,11 @@ use Wikibase\DataModel\SiteLink; use Wikibase\EntityId; use Wikibase\EntityTitleLookup; -use Wikibase\i18n\MessageParameterFormatter; +use Wikibase\Lib\Localizer\MessageParameterFormatter; /** * @property mixed getMockValueFormatter - * @covers Wikibase\i18n\MessageParameterFormatter + * @covers Wikibase\Lib\Localizer\MessageParameterFormatter * * @group Wikibase * @group WikibaseLib diff --git a/lib/tests/phpunit/i18n/WikibaseExceptionLocalizerTest.php b/lib/tests/phpunit/Localizer/WikibaseExceptionLocalizerTest.php similarity index 95% rename from lib/tests/phpunit/i18n/WikibaseExceptionLocalizerTest.php rename to lib/tests/phpunit/Localizer/WikibaseExceptionLocalizerTest.php index 16e8b4e..0fa4124 100644 --- a/lib/tests/phpunit/i18n/WikibaseExceptionLocalizerTest.php +++ b/lib/tests/phpunit/Localizer/WikibaseExceptionLocalizerTest.php @@ -10,10 +10,10 @@ use ValueValidators\Result; use Wikibase\ChangeOp\ChangeOpValidationException; use Wikibase\DataModel\SiteLink; -use Wikibase\i18n\WikibaseExceptionLocalizer; +use Wikibase\Lib\Localizer\WikibaseExceptionLocalizer; /** - * @covers Wikibase\i18n\WikibaseExceptionLocalizer + * @covers Wikibase\Lib\Localizer\WikibaseExceptionLocalizer * * @group Wikibase * @group WikibaseLib diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php index aef393c..8c11b3b 100644 --- a/repo/includes/WikibaseRepo.php +++ b/repo/includes/WikibaseRepo.php @@ -16,15 +16,15 @@ use Wikibase\DataModel\Entity\Property; use Wikibase\EntityContentFactory; use Wikibase\EntityLookup; -use Wikibase\i18n\ExceptionLocalizer; -use Wikibase\i18n\MessageParameterFormatter; -use Wikibase\i18n\WikibaseExceptionLocalizer; use Wikibase\LanguageFallbackChainFactory; use Wikibase\Lib\ClaimGuidGenerator; use Wikibase\Lib\ClaimGuidValidator; use Wikibase\Lib\DispatchingValueFormatter; use Wikibase\Lib\EntityIdLinkFormatter; use Wikibase\Lib\EntityRetrievingDataTypeLookup; +use Wikibase\Lib\Localizer\ExceptionLocalizer; +use Wikibase\Lib\Localizer\MessageParameterFormatter; +use Wikibase\Lib\Localizer\WikibaseExceptionLocalizer; use Wikibase\Lib\OutputFormatSnakFormatterFactory; use Wikibase\Lib\OutputFormatValueFormatterFactory; use Wikibase\Lib\PropertyDataTypeLookup; diff --git a/repo/includes/api/ApiErrorReporter.php b/repo/includes/api/ApiErrorReporter.php index 1cc78dd..8fdac4c 100644 --- a/repo/includes/api/ApiErrorReporter.php +++ b/repo/includes/api/ApiErrorReporter.php @@ -10,7 +10,7 @@ use LogicException; use Message; use Status; -use Wikibase\i18n\ExceptionLocalizer; +use Wikibase\Lib\Localizer\ExceptionLocalizer; /** * ApiErrorReporter is a component for API modules that handles diff --git a/repo/includes/api/ApiWikibase.php b/repo/includes/api/ApiWikibase.php index 33e2bc1..c6a42e0 100644 --- a/repo/includes/api/ApiWikibase.php +++ b/repo/includes/api/ApiWikibase.php @@ -18,7 +18,7 @@ use Wikibase\EntityRevision; use Wikibase\EntityRevisionLookup; use Wikibase\EntityTitleLookup; -use Wikibase\i18n\ExceptionLocalizer; +use Wikibase\Lib\Localizer\ExceptionLocalizer; use Wikibase\Lib\PropertyDataTypeLookup; use Wikibase\Lib\Serializers\SerializerFactory; use Wikibase\Repo\WikibaseRepo; diff --git a/repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php b/repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php index 6baf178..edebe42 100644 --- a/repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php +++ b/repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php @@ -12,7 +12,7 @@ use Wikibase\DataModel\Claim\Claims; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Snak\PropertyValueSnak; -use Wikibase\i18n\WikibaseExceptionLocalizer; +use Wikibase\Lib\Localizer\WikibaseExceptionLocalizer; use Wikibase\Repo\WikibaseRepo; /** -- To view, visit https://gerrit.wikimedia.org/r/131903 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0b7916b900ce747b166e49a8a40ab3f9acd098d Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
