Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/137541

Change subject: Respect Upload Settings when show upload buttons
......................................................................

Respect Upload Settings when show upload buttons

Extend disableImages in MobileContext to check for permission
and enabled Upload of Images. Return only true, if user is allowed to
upload and upload is enabled in LocalSettings.

Bug: 66164
Change-Id: I84b71dab067d6eec294c38969ecf37f6e9134040
---
M includes/MobileContext.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/41/137541/1

diff --git a/includes/MobileContext.php b/includes/MobileContext.php
index 231015d..944cea6 100644
--- a/includes/MobileContext.php
+++ b/includes/MobileContext.php
@@ -90,6 +90,9 @@
                if ( is_null( $this->disableImages ) ) {
                        $this->disableImages = 
(bool)$this->getRequest()->getCookie( 'disableImages' );
                }
+               if ( !UploadBase::isEnabled() || UploadBase::isAllowed( 
$this->getUser() ) === false ) {
+                       $this->disableImages = true;
+               }
 
                return $this->disableImages;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/137541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I84b71dab067d6eec294c38969ecf37f6e9134040
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to