Lcarr has submitted this change and it was merged.
Change subject: Revert "Adding icinga check to make sure kafka brokers aren't
getting too many produce requests"
......................................................................
Revert "Adding icinga check to make sure kafka brokers aren't getting too many
produce requests"
This reverts commit 6e626a9dc32d7d99d2070844315a0b04e03865da.
Change-Id: I87c3ad44806db2d549940e8702e791d8692d2893
---
M manifests/misc/analytics.pp
M templates/icinga/checkcommands.cfg.erb
2 files changed, 6 insertions(+), 18 deletions(-)
Approvals:
Lcarr: Looks good to me, approved
jenkins-bot: Verified
diff --git a/manifests/misc/analytics.pp b/manifests/misc/analytics.pp
index c190eea..cf598fa 100644
--- a/manifests/misc/analytics.pp
+++ b/manifests/misc/analytics.pp
@@ -29,16 +29,10 @@
class misc::analytics::monitoring::kafka::server {
# Set up icinga monitoring of Kafka broker server produce requests per
second.
# If this drops too low, trigger an alert
- monitor_service { 'kafka_broker-ProduceRequestsPerSecond':
- description =>
'kafka_network_SocketServerStats.ProduceRequestsPerSecond',
- check_command => 'check_kafka_broker_produce_requests_min!2!1',
- contact_group => 'analytics',
- }
- # Set up icinga monitoring of Kafka broker server produce requests per
second.
- # If this drops too high, trigger an alert
- monitor_service { 'kafka_broker-ProduceRequestsPerSecond':
- description =>
'kafka_network_SocketServerStats.ProduceRequestsPerSecond',
- check_command =>
'check_kafka_broker_produce_requests_max!15!20',
- contact_group => 'analytics',
+ # for this udp2log instance.
+ monitor_service { "kakfa-broker-ProduceRequestsPerSecond":
+ description =>
"kafka_network_SocketServerStats.ProduceRequestsPerSecond",
+ check_command =>
"check_kafka_broker_produce_requests!2!1",
+ contact_group => "analytics",
}
}
diff --git a/templates/icinga/checkcommands.cfg.erb
b/templates/icinga/checkcommands.cfg.erb
index b40ea35..b156f7e 100644
--- a/templates/icinga/checkcommands.cfg.erb
+++ b/templates/icinga/checkcommands.cfg.erb
@@ -617,14 +617,8 @@
# Analytics Kraken checks
# Check that Kafka Brokers are getting ProduceRequests.
define command{
- command_name check_kafka_broker_produce_requests_min
+ command_name check_kafka_broker_produce_requests
command_line $USER1$/check_ganglios_generic_value -H $HOSTADDRESS$
-m kafka_network_SocketServerStats.ProduceRequestsPerSecond -w $ARG1$ -c $ARG2$
-o lt
-}
-
-# Check that Kafka Brokers aren't getting TOO many ProduceRequests
-define command{
- command_name check_kafka_producer_produce_requests_max
- command_line $USER1$/check_ganglios_generic_value -H $HOSTADDRESS$
-m kafka_network_SocketServerStats.ProduceRequestsPerSecond -w $ARG1$ -c $ARG2$
-o gt
}
# Alerts for data loss in Kraken HDFS.
--
To view, visit https://gerrit.wikimedia.org/r/72052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87c3ad44806db2d549940e8702e791d8692d2893
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Lcarr <lc...@wikimedia.org>
Gerrit-Reviewer: Lcarr <lc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
