Phuedx has uploaded a new change for review. https://gerrit.wikimedia.org/r/208953
Change subject: Revert "Append drawers to body so they can work in other skins" ...................................................................... Revert "Append drawers to body so they can work in other skins" This reverts commit c3553073c1440ac2c27613a5481b40815c7f5ca9. Bug: T97621 Change-Id: If2c2e90ec780998bd2185d9648469c60d2494073 --- M resources/mobile.drawers/Drawer.js M resources/mobile.startup/init.js 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/53/208953/1 diff --git a/resources/mobile.drawers/Drawer.js b/resources/mobile.drawers/Drawer.js index 3ee2e37..d4e627c 100644 --- a/resources/mobile.drawers/Drawer.js +++ b/resources/mobile.drawers/Drawer.js @@ -14,7 +14,7 @@ * Defines an element that the Drawer should automatically be appended to. * @property {String} */ - appendToElement: 'body', + appendToElement: '#mw-mf-viewport', closeOnScroll: true, events: $.extend( {}, Panel.prototype.events, { click: 'stopPropagation' diff --git a/resources/mobile.startup/init.js b/resources/mobile.startup/init.js index 814dca6..92d7ea1 100644 --- a/resources/mobile.startup/init.js +++ b/resources/mobile.startup/init.js @@ -15,7 +15,7 @@ Skin = M.require( 'Skin' ); skin = new Skin( { - el: 'body', + el: '#mw-mf-viewport', tabletModules: mw.config.get( 'skin' ) === 'minerva' ? [ 'tablet.scripts' ] : [], page: getCurrentPage(), mainMenu: new MainMenu() -- To view, visit https://gerrit.wikimedia.org/r/208953 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2c2e90ec780998bd2185d9648469c60d2494073 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Phuedx <g...@samsmith.io> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits