Mwjames has uploaded a new change for review. Change subject: Reworked and repaired Special:SearchByProperty ......................................................................
Reworked and repaired Special:SearchByProperty This special page did not sort smaller nearby values correctly (nearby values are displayed for numerical properties for which only very few or no exact results are found; try Modification date). Besides this bug, the code was a mess (still is to some extent, but it is better) and did quite few things wrong. Works better now. Main changes: * Fix sorting of results (problem was due to a use of array_reverse) * Fix query generation (queries were created by building strings and parsing them! now the query is just created as an object) * Rename many variables and a method to make some sense * Some added docs * Separate parameter reading from execute(); new method now; better/clearer defaults * Improved code clarity in various places * Fixed wrong HTML generation in the case where a few exact matches are displayed in between inexact matches (the exact matches would be surrounded by as many <strong> tags as there are matches in the old code; works but makes no sense at all) Change-Id: I390f514f4f4d76e51f0555123904c9ea32319ad1 --- M specials/SearchTriple/SMW_SpecialSearchByProperty.php 1 file changed, 230 insertions(+), 187 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/44/32344/1 -- To view, visit https://gerrit.wikimedia.org/r/32344 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I390f514f4f4d76e51f0555123904c9ea32319ad1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: 1.9.x Gerrit-Owner: Mwjames <jamesin.hongkon...@gmail.com> Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
