Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/254838
Change subject: RuboCop: fixed Lint/UnusedMethodArgument offense ...................................................................... RuboCop: fixed Lint/UnusedMethodArgument offense More info: https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars Bug: T112651 Change-Id: I84ba8d9b14b1e508615cd723365c13bf70830d22 --- M .rubocop_todo.yml M modules/wmflib/lib/hiera/backend/role_backend.rb M modules/wmflib/lib/hiera/mwcache.rb 3 files changed, 2 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/38/254838/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 00cac4f..f5028a3 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -34,14 +34,6 @@ - 'modules/base/files/monitoring/check_puppetrun' - 'modules/ganglia/lib/puppet/parser/functions/ganglia_aggregator_config.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. -Lint/UnusedMethodArgument: - Exclude: - - 'modules/wmflib/lib/hiera/backend/role_backend.rb' - - 'modules/wmflib/lib/hiera/mwcache.rb' - # Offense count: 10 Lint/UselessAssignment: Exclude: diff --git a/modules/wmflib/lib/hiera/backend/role_backend.rb b/modules/wmflib/lib/hiera/backend/role_backend.rb index c876340..32b312a 100644 --- a/modules/wmflib/lib/hiera/backend/role_backend.rb +++ b/modules/wmflib/lib/hiera/backend/role_backend.rb @@ -74,7 +74,7 @@ @cache = cache || Filecache.new end - def get_path(key, role, source, scope) + def get_path(_key, role, source, scope) config_section = :role # Special case: 'private' repository. diff --git a/modules/wmflib/lib/hiera/mwcache.rb b/modules/wmflib/lib/hiera/mwcache.rb index 94d4b1b..0f0e4b3 100644 --- a/modules/wmflib/lib/hiera/mwcache.rb +++ b/modules/wmflib/lib/hiera/mwcache.rb @@ -34,7 +34,7 @@ raise error end - def read_file(path, expected_type = Object, &block) + def read_file(path, expected_type = Object, &_block) if stale?(path) resp = get_from_mediawiki(path, true) data = resp["*"] -- To view, visit https://gerrit.wikimedia.org/r/254838 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I84ba8d9b14b1e508615cd723365c13bf70830d22 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
