Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/242786
Change subject: Seperate distinct value checks ...................................................................... Seperate distinct value checks As partially suggted by aude in https://gerrit.wikimedia.org/r/#/c/232279/8/specials/SpecialCrossCheck.php Change-Id: I9425bd2bcd95151597dd7d3889cdf4853a2319cb --- M specials/SpecialCrossCheck.php 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation refs/changes/86/242786/1 diff --git a/specials/SpecialCrossCheck.php b/specials/SpecialCrossCheck.php index c13294c..c064357 100644 --- a/specials/SpecialCrossCheck.php +++ b/specials/SpecialCrossCheck.php @@ -12,6 +12,7 @@ use Traversable; use ValueFormatters\FormatterOptions; use ValueFormatters\ValueFormatter; +use Wikibase\DataModel\Entity\EntityDocument; use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\EntityIdParser; use Wikibase\DataModel\Entity\EntityIdParsingException; @@ -171,16 +172,16 @@ return; } - if ( !( $entity instanceof StatementListProvider ) ) { + if ( $entity === null ) { $out->addHTML( $this->buildNotice('wbqev-crosscheck-not-existent-entity', true) ); return; } - $results = $this->crossCheckInteractor->crossCheckEntity( $entity->getStatements() ); + $results = $this->getCrossCheckResultsFromEntity( $entity ); - if ($results && count($results) > 0) { + if ( count($results) > 0 ) { $out->addHTML( $this->buildResultHeader($entityId) . $this->buildSummary($results) @@ -196,6 +197,19 @@ } /** + * @param EntityDocument $entity + * + * @return CrossCheckResultList + */ + private function getCrossCheckResultsFromEntity( EntityDocument $entity ) { + if ( $entity instanceof StatementListProvider ) { + return $this->crossCheckInteractor->crossCheckEntity( $entity->getStatements() ); + } + + return new CrossCheckResultList(); + } + + /** * Builds html form for entity id input */ private function buildEntityIdForm() { -- To view, visit https://gerrit.wikimedia.org/r/242786 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9425bd2bcd95151597dd7d3889cdf4853a2319cb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
