Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/70601


Change subject: Sort the language modules based on id
......................................................................

Sort the language modules based on id

Bug: 49735
Change-Id: I82e0d47781f982dd1a6ea7cc1e3cbe07bfd6b616
---
M resources/js/ext.uls.languagesettings.js
1 file changed, 9 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/01/70601/1

diff --git a/resources/js/ext.uls.languagesettings.js 
b/resources/js/ext.uls.languagesettings.js
index c8cbc86..70f8d70 100644
--- a/resources/js/ext.uls.languagesettings.js
+++ b/resources/js/ext.uls.languagesettings.js
@@ -71,19 +71,25 @@
 
                render: function () {
                        var moduleName,
+                               modules,
+                               languageSettings = this,
                                defaultModule = this.options.defaultModule;
 
                        // Get the name of all registered modules and list them 
in left side menu.
-                       for ( moduleName in $.fn.languagesettings.modules ) {
+                       // Sort the modules based on id
+                       modules = $.map( $.fn.languagesettings.modules, 
function( element, index ) {
+                               return index ;
+                       } ).sort();
+                       $.each( modules, function( index, moduleName ) {
                                if ( 
$.fn.languagesettings.modules.hasOwnProperty( moduleName ) ) {
                                        if ( !defaultModule ) {
                                                defaultModule = moduleName;
                                        }
 
                                        // Call render function on the current 
setting module.
-                                       this.renderModule( moduleName, 
defaultModule === moduleName );
+                                       languageSettings.renderModule( 
moduleName, defaultModule === moduleName );
                                }
-                       }
+                       } );
                },
 
                /**

-- 
To view, visit https://gerrit.wikimedia.org/r/70601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82e0d47781f982dd1a6ea7cc1e3cbe07bfd6b616
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to