jenkins-bot has submitted this change and it was merged.

Change subject: Title: Fix inaccurate documentation of 
getUserPermissionsErrorsInternal
......................................................................


Title: Fix inaccurate documentation of getUserPermissionsErrorsInternal

Blocks are checked (checkUserBlock).

Change-Id: I3a164d1003f2bea3e3e07081c9bebfabd884ade9
---
M includes/Title.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Title.php b/includes/Title.php
index 0ac3e46..960832c 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -2452,8 +2452,8 @@
 
        /**
         * Can $user perform $action on this page? This is an internal function,
-        * which checks ONLY that previously checked by userCan (i.e. it leaves 
out
-        * checks on wfReadOnly() and blocks)
+        * with multiple levels of checks depending on performance needs; see 
$rigor below.
+        * It does not check wfReadOnly().
         *
         * @param string $action Action that permission needs to be checked for
         * @param User $user User to check

-- 
To view, visit https://gerrit.wikimedia.org/r/278424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3a164d1003f2bea3e3e07081c9bebfabd884ade9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to