Bartosz Dziewoński has submitted this change and it was merged.
Change subject: UploadFromUrl: Display an error to the user on invalid
wpUploadFileURL
......................................................................
UploadFromUrl: Display an error to the user on invalid wpUploadFileURL
Removes check for URL validity from UploadFromUrl::isValidRequest()
so that an error can be thrown later and displayed to the user.
Bug: T34361
Change-Id: Idf4cfcd6199ef6e875f760e46db98248ba53a327
---
M includes/upload/UploadFromUrl.php
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Verified; Looks good to me, approved
diff --git a/includes/upload/UploadFromUrl.php
b/includes/upload/UploadFromUrl.php
index f578745..f897a79 100644
--- a/includes/upload/UploadFromUrl.php
+++ b/includes/upload/UploadFromUrl.php
@@ -175,7 +175,6 @@
$url = $request->getVal( 'wpUploadFileURL' );
return !empty( $url )
- && Http::isValidURI( $url )
&& $wgUser->isAllowed( 'upload_by_url' );
}
--
To view, visit https://gerrit.wikimedia.org/r/139696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf4cfcd6199ef6e875f760e46db98248ba53a327
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Rohan013 <rohan1...@yahoo.com>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: btongminh <bryan.tongm...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
