Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/300558
Change subject: Use ConfigFactory instead of globals
......................................................................
Use ConfigFactory instead of globals
Change-Id: I05d6bbd43dad693ad989fe685b1ee906e7a2b551
---
M extension.json
M includes/auth/MinimumNameLengthPreAuthenticationProvider.php
2 files changed, 9 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MinimumNameLength
refs/changes/58/300558/1
diff --git a/extension.json b/extension.json
index c6844cc..b9c8732 100644
--- a/extension.json
+++ b/extension.json
@@ -18,6 +18,9 @@
"i18n"
]
},
+ "ConfigRegistry": {
+ "minimumnamelength": "GlobalVarConfig::newInstance"
+ },
"AutoloadClasses": {
"MinimumNameLengthPreAuthenticationProvider":
"includes/auth/MinimumNameLengthPreAuthenticationProvider.php"
},
diff --git a/includes/auth/MinimumNameLengthPreAuthenticationProvider.php
b/includes/auth/MinimumNameLengthPreAuthenticationProvider.php
index 68daa1e..9f0ff95 100644
--- a/includes/auth/MinimumNameLengthPreAuthenticationProvider.php
+++ b/includes/auth/MinimumNameLengthPreAuthenticationProvider.php
@@ -9,12 +9,15 @@
class MinimumNameLengthPreAuthenticationProvider extends
\MediaWiki\Auth\AbstractPreAuthenticationProvider {
public function testUserForCreation( $user, $autocreate, array $options
= [] ) {
- global $wgMinimumUsernameLength;
+ $minimumNameLength = \MediaWiki\MediaWikiServices::getInstance()
+ ->getConfigFactory()
+ ->makeConfig( 'minimumnamelength' )
+ ->get( 'MinimumUsernameLength' );
$value = StatusValue::newGood();
- if( strlen( $user->getName() ) < $wgMinimumUsernameLength ) {
+ if( strlen( $user->getName() ) < $minimumNameLength ) {
$value = StatusValue::newFatal(
- wfMessage( 'minimumnamelength-error'
)->numParams( $wgMinimumUsernameLength )
+ wfMessage( 'minimumnamelength-error'
)->numParams( $minimumNameLength )
);
}
return $value;
--
To view, visit https://gerrit.wikimedia.org/r/300558
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05d6bbd43dad693ad989fe685b1ee906e7a2b551
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MinimumNameLength
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
