Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/274938

Change subject: WIP MediawikiSelenium::ConfigurationError is raised if a 
configuration is empty string
......................................................................

WIP MediawikiSelenium::ConfigurationError is raised if a configuration is empty 
string

Bug: T128860
Change-Id: I18a86610309fe5bc40f53b57ce604cd0e8290957
---
M spec/environment_spec.rb
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/38/274938/1

diff --git a/spec/environment_spec.rb b/spec/environment_spec.rb
index 833882a..defd7b0 100644
--- a/spec/environment_spec.rb
+++ b/spec/environment_spec.rb
@@ -47,6 +47,14 @@
         expect(subject[:y]).to eq('b')
       end
 
+      context 'when the given environment is empty string' do
+        let(:extra) { { z: '' } }
+
+        it 'returns a new environment' do
+          expect(subject[:z]).to eq('')
+        end
+      end
+
       context 'when the given environment does not exist in 
`environments.yml`' do
         let(:name) { 'bar' }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/274938
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I18a86610309fe5bc40f53b57ce604cd0e8290957
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to