Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/269995
Change subject: WIP cleaning up Selenium tests ...................................................................... WIP cleaning up Selenium tests Bug: T120715 Change-Id: Ib57f48b01d909915ae44976aa51824b4530ffffc --- M tests/browser/features/read_more.feature D tests/browser/features/support/pages/login_page.rb M tests/browser/features/support/step_definitions/common_steps.rb 3 files changed, 1 insertion(+), 21 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles refs/changes/95/269995/1 diff --git a/tests/browser/features/read_more.feature b/tests/browser/features/read_more.feature index 140321b..3a899cc 100644 --- a/tests/browser/features/read_more.feature +++ b/tests/browser/features/read_more.feature @@ -27,7 +27,7 @@ @extension-betafeatures Scenario: ReadMore is present when enabled as a BetaFeature - Given I am logged into the website + Given I am logged in And ReadMore is enabled as a beta feature And I am on the "Related Articles 1" page And page has fully loaded with ReadMore code diff --git a/tests/browser/features/support/pages/login_page.rb b/tests/browser/features/support/pages/login_page.rb deleted file mode 100644 index 6fd0eb9..0000000 --- a/tests/browser/features/support/pages/login_page.rb +++ /dev/null @@ -1,16 +0,0 @@ -class LoginPage - include PageObject - page_url 'Special:Userlogin' - - text_field(:username, name: 'wpName') - text_field(:password, name: 'wpPassword') - - def login_with(username, password) - # deal with autocomplete - username_element.when_present.clear - - self.username = username - self.password = password - login - end -end diff --git a/tests/browser/features/support/step_definitions/common_steps.rb b/tests/browser/features/support/step_definitions/common_steps.rb index 2e18796..c05be93 100644 --- a/tests/browser/features/support/step_definitions/common_steps.rb +++ b/tests/browser/features/support/step_definitions/common_steps.rb @@ -36,10 +36,6 @@ end end -Given(/^I am logged into the website$/) do - visit(LoginPage).login_with(user, password) -end - Given(/^I am on the "(.*?)" page/) do |arg1| visit(ArticlePage, using_params: { article_name: arg1 }) end -- To view, visit https://gerrit.wikimedia.org/r/269995 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib57f48b01d909915ae44976aa51824b4530ffffc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/RelatedArticles Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits