Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/119270
Change subject: WIP mediawiki_selenium Ruby gem should be able to start local
and remote browsers with optional browser setup
......................................................................
WIP mediawiki_selenium Ruby gem should be able to start local and remote
browsers with optional browser setup
Paired with Kartik Mistry.
Bug: 62512
Change-Id: I61e5b688711b1976e8df8be94972fe35f6eeb9aa
---
M tests/browser/features/accept_language.feature
M tests/browser/features/step_definitions/accept_language_steps.rb
2 files changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/70/119270/1
diff --git a/tests/browser/features/accept_language.feature
b/tests/browser/features/accept_language.feature
index f8c982d..8c65bf3 100644
--- a/tests/browser/features/accept_language.feature
+++ b/tests/browser/features/accept_language.feature
@@ -1,4 +1,4 @@
-@custom-browser @phantomjs-bug @sandbox.translatewiki.net
+@custom-browser @sandbox.translatewiki.net
Feature: Accept-Language
Scenario Outline: Accept-Language
diff --git a/tests/browser/features/step_definitions/accept_language_steps.rb
b/tests/browser/features/step_definitions/accept_language_steps.rb
index 4579f51..012debd 100644
--- a/tests/browser/features/step_definitions/accept_language_steps.rb
+++ b/tests/browser/features/step_definitions/accept_language_steps.rb
@@ -1,5 +1,5 @@
Given(/^that my browser's accept language is (.+)$/) do |language|
- @browser = browser(environment, test_name(@scenario), language)
+ @browser = browser(test_name(@scenario), {language: language})
$session_id = @browser.driver.instance_variable_get(:@bridge).session_id
end
--
To view, visit https://gerrit.wikimedia.org/r/119270
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61e5b688711b1976e8df8be94972fe35f6eeb9aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
