Jeroen De Dauw has submitted this change and it was merged.
Change subject: Work on cleaning up EntityDiff
......................................................................
Work on cleaning up EntityDiff
Patchset 12: Patching operated on a copy, changed
to operation of the original.
Patchset 13: Switched a test that previously had
its then- and elseclauses switched.
Patchset 14: Changed base to current during patching,
added an additional testcase for a change of
diff op.
Change-Id: I877d690f3872fdee7c7946a646faf25e47c2ccd7
---
M lib/WikibaseLib.php
M lib/includes/entity/Entity.php
M lib/includes/entity/EntityDiff.php
M lib/includes/entity/EntityDiffView.php
M lib/includes/item/Item.php
M lib/includes/item/ItemDiff.php
D lib/includes/item/ItemDiffView.php
M lib/includes/property/Property.php
D lib/includes/property/PropertyDiff.php
D lib/includes/property/PropertyDiffView.php
M lib/includes/query/Query.php
M lib/tests/phpunit/ChangesTableTest.php
M lib/tests/phpunit/changes/EntityChangeTest.php
M lib/tests/phpunit/entity/EntityDiffTest.php
M lib/tests/phpunit/entity/EntityTest.php
M lib/tests/phpunit/entity/EntityTestCase.php
M lib/tests/phpunit/item/ItemDiffTest.php
M lib/tests/phpunit/item/ItemTest.php
M lib/tests/phpunit/property/PropertyDiffTest.php
M repo/includes/EditEntity.php
M repo/includes/EntityContentDiffView.php
M repo/includes/actions/EditEntityAction.php
M repo/tests/phpunit/includes/EditEntityTest.php
23 files changed, 545 insertions(+), 601 deletions(-)
Approvals:
Jeroen De Dauw: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/39229
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I877d690f3872fdee7c7946a646faf25e47c2ccd7
Gerrit-PatchSet: 15
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: John Erling Blad <john.b...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
