Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290357
Change subject: build: Align to stylelint-config-wikimedia for string quotes
......................................................................
build: Align to stylelint-config-wikimedia for string quotes
Change-Id: Ia5f30ee286cb2936cb564b540fa9000b7826dcde
---
M .stylelintrc
M demos/styles/demo.css
M src/styles/common.less
M src/styles/layouts/FieldLayout.less
M src/styles/widgets/NumberInputWidget.less
M src/styles/widgets/SelectFileWidget.less
M src/styles/widgets/TextInputWidget.less
M src/themes/apex/widgets.less
M src/themes/mediawiki/widgets.less
9 files changed, 20 insertions(+), 22 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/57/290357/1
diff --git a/.stylelintrc b/.stylelintrc
index 5595bb6..6f232ea 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -6,9 +6,7 @@
"block-no-empty": null,
"block-no-single-line": null,
"declaration-no-important": null,
- "font-family-name-quotes": [ "double-where-recommended" ],
"no-descending-specificity": null,
- "string-no-newline": true,
- "string-quotes": null
+ "string-no-newline": true
}
}
diff --git a/demos/styles/demo.css b/demos/styles/demo.css
index 1e3fda9..8a872dc 100644
--- a/demos/styles/demo.css
+++ b/demos/styles/demo.css
@@ -136,7 +136,7 @@
line-height: 1.6em;
color: #999;
text-align: center;
- content: "→";
+ content: '→';
}
.oo-ui-demo-console-toggle:hover::after,
@@ -146,7 +146,7 @@
}
.oo-ui-demo-console-expanded .oo-ui-demo-console-toggle::after {
- content: "↑";
+ content: '↑';
}
.oo-ui-demo-console-collapsed .oo-ui-demo-console-log,
@@ -180,7 +180,7 @@
width: 20px;
text-align: center;
bottom: 0;
- content: "→";
+ content: '→';
}
.oo-ui-demo-console-log-line-error {
diff --git a/src/styles/common.less b/src/styles/common.less
index 0f45c39..ddc26eb 100644
--- a/src/styles/common.less
+++ b/src/styles/common.less
@@ -39,14 +39,14 @@
}
.oo-ui-animation( @value1, @value2: X, ... ) {
- @value: ~`"@{arguments}".replace( /[\[\]]|\,\sX/g, '' )`; //
stylelint-disable-line function-comma-space-after, function-whitespace-after
+ @value: ~`"@{arguments}".replace( /[\[\]]|\,\sX/g, '' )`; //
stylelint-disable-line function-comma-space-after, function-whitespace-after,
string-quotes
-webkit-animation: @value;
-moz-animation: @value;
animation: @value;
}
.oo-ui-transition( @value1, @value2: X, ... ) {
- @value: ~`"@{arguments}".replace( /[\[\]]|\,\sX/g, '' )`; //
stylelint-disable-line function-comma-space-after, function-whitespace-after
+ @value: ~`"@{arguments}".replace( /[\[\]]|\,\sX/g, '' )`; //
stylelint-disable-line function-comma-space-after, function-whitespace-after,
string-quotes
-webkit-transition: @value;
-moz-transition: @value;
transition: @value;
@@ -81,7 +81,7 @@
// accept them.
@start-ie: argb( rgba( red( @start ), green( @start ), blue( @start ),
alpha( @start ) ) );
@stop-ie: argb( rgba( red( @stop ), green( @stop ), blue( @stop ),
alpha( @stop ) ) );
- -ms-filter: "progid:DXImageTransform.Microsoft.gradient(
startColorstr='@{start-ie}', endColorstr='@{stop-ie}' )";
+ -ms-filter: "progid:DXImageTransform.Microsoft.gradient(
startColorstr='@{start-ie}', endColorstr='@{stop-ie}' )"; //
stylelint-disable-line string-quotes
}
.oo-ui-unselectable() {
diff --git a/src/styles/layouts/FieldLayout.less
b/src/styles/layouts/FieldLayout.less
index 799f9f4..dd15d3d 100644
--- a/src/styles/layouts/FieldLayout.less
+++ b/src/styles/layouts/FieldLayout.less
@@ -5,7 +5,7 @@
&:before,
&:after {
- content: " ";
+ content: ' ';
display: table;
}
diff --git a/src/styles/widgets/NumberInputWidget.less
b/src/styles/widgets/NumberInputWidget.less
index 2a9ea3d..23107fb 100644
--- a/src/styles/widgets/NumberInputWidget.less
+++ b/src/styles/widgets/NumberInputWidget.less
@@ -19,13 +19,13 @@
&-field > .oo-ui-textInputWidget {
width: 100%;
- [type="number"]::-webkit-outer-spin-button,
- [type="number"]::-webkit-inner-spin-button {
+ [type='number']::-webkit-outer-spin-button,
+ [type='number']::-webkit-inner-spin-button {
-webkit-appearance: none;
margin: 0;
}
- [type="number"] {
+ [type='number'] {
-moz-appearance: textfield;
}
}
diff --git a/src/styles/widgets/SelectFileWidget.less
b/src/styles/widgets/SelectFileWidget.less
index d8d14c1..150b54e 100644
--- a/src/styles/widgets/SelectFileWidget.less
+++ b/src/styles/widgets/SelectFileWidget.less
@@ -12,7 +12,7 @@
position: relative;
overflow: hidden;
- > [type="file"] {
+ > [type='file'] {
position: absolute;
top: 0;
bottom: 0;
@@ -29,7 +29,7 @@
}
&.oo-ui-widget-disabled {
- & > .oo-ui-buttonElement-button > [type="file"] {
+ & > .oo-ui-buttonElement-button > [type='file'] {
display: none;
}
}
diff --git a/src/styles/widgets/TextInputWidget.less
b/src/styles/widgets/TextInputWidget.less
index 43c0b1b..d807a55 100644
--- a/src/styles/widgets/TextInputWidget.less
+++ b/src/styles/widgets/TextInputWidget.less
@@ -21,7 +21,7 @@
// Normalize styling for `<input type=search>` and
// remove proprietary vendor UI extensions
- [type="search"] {
+ [type='search'] {
// Safari 5, Chrome
-webkit-appearance: textfield;
diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index 8f30907..7d91732 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -825,7 +825,7 @@
.oo-ui-popupWidget-anchor:before,
.oo-ui-popupWidget-anchor:after {
- content: "";
+ content: '';
position: absolute;
width: 0;
height: 0;
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index bf80133..2b49b7a 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -353,7 +353,7 @@
}
// `<input type=checkbox>` element is visually replaced by `span` that
follows
- [type="checkbox"] {
+ [type='checkbox'] {
// Use opacity so that VoiceOver can still identify it
opacity: 0;
// Render "on top of" the span, so that it's still clickable
@@ -476,7 +476,7 @@
}
// `<input type=radio>` element is visually replaced by `span` that
follows
- [type="radio"] {
+ [type='radio'] {
// Use opacity so that VoiceOver can still identify it
opacity: 0;
// Render "on top of" the span, so that it's still clickable
@@ -1056,7 +1056,7 @@
.oo-ui-popupWidget-anchor:before,
.oo-ui-popupWidget-anchor:after {
- content: "";
+ content: '';
position: absolute;
width: 0;
height: 0;
@@ -1166,7 +1166,7 @@
outline: 0;
.oo-ui-radioOptionWidget.oo-ui-optionWidget-selected {
- .oo-ui-radioInputWidget [type="radio"] + span {
+ .oo-ui-radioInputWidget [type='radio'] + span {
border-width: @border-width-input-binary-focus;
}
}
@@ -1227,7 +1227,7 @@
);
&:before {
- content: "";
+ content: '';
display: block;
position: absolute;
top: 0;
--
To view, visit https://gerrit.wikimedia.org/r/290357
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5f30ee286cb2936cb564b540fa9000b7826dcde
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
