jenkins-bot has submitted this change and it was merged.
Change subject: ce.Surface: Remove unused clone of copied data in #onCopy
......................................................................
ce.Surface: Remove unused clone of copied data in #onCopy
The pasteData variable wasn't used, so we were wastefully
copying the copied data a second time.
Change-Id: I525f2ab72e4c90879414338fa1509b99f0555ae4
---
M src/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index c08c8a0..f84c486 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -1548,7 +1548,7 @@
*/
ve.ce.Surface.prototype.onCopy = function ( e ) {
var originalRange,
- clipboardIndex, clipboardItem, pasteData,
+ clipboardIndex, clipboardItem,
scrollTop, unsafeSelector, range, slice,
selection = this.getModel().getSelection(),
view = this,
@@ -1566,8 +1566,6 @@
}
slice = this.model.documentModel.cloneSliceFromRange( range );
-
- pasteData = slice.data.clone();
// Clone the elements in the slice
slice.data.cloneElements( true );
--
To view, visit https://gerrit.wikimedia.org/r/203470
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I525f2ab72e4c90879414338fa1509b99f0555ae4
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
