Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/218279
Change subject: fixup! OOUIHTMLForm: Implement HTMLMultiSelectField ...................................................................... fixup! OOUIHTMLForm: Implement HTMLMultiSelectField Change-Id: I9bb8d1fbb684720fe3e34d07ce4ef14572602726 --- M includes/htmlform/HTMLCheckMatrix.php M includes/htmlform/HTMLMultiSelectField.php 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/79/218279/1 diff --git a/includes/htmlform/HTMLCheckMatrix.php b/includes/htmlform/HTMLCheckMatrix.php index ce83499..a0566a0 100644 --- a/includes/htmlform/HTMLCheckMatrix.php +++ b/includes/htmlform/HTMLCheckMatrix.php @@ -156,7 +156,7 @@ return new OOUI\CheckboxInputWidget( array( 'name' => "{$this->mName}[]", 'selected' => $checked, - 'value' => '1', + 'value' => $attribs['value'], ) + $attribs ); } else { $checkbox = Xml::check( "{$this->mName}[]", $checked, $attribs ); diff --git a/includes/htmlform/HTMLMultiSelectField.php b/includes/htmlform/HTMLMultiSelectField.php index d2acc2f..523f045 100644 --- a/includes/htmlform/HTMLMultiSelectField.php +++ b/includes/htmlform/HTMLMultiSelectField.php @@ -72,7 +72,7 @@ new OOUI\CheckboxInputWidget( array( 'name' => "{$this->mName}[]", 'selected' => $checked, - 'value' => '1', + 'value' => $attribs['value'], ) + $attribs ), array( 'label' => $label, -- To view, visit https://gerrit.wikimedia.org/r/218279 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9bb8d1fbb684720fe3e34d07ce4ef14572602726 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits