Hashar has submitted this change and it was merged.
Change subject: lines longer than 100 will simply warn (no error)
......................................................................
lines longer than 100 will simply warn (no error)
Generic.Files.LineLength sniff will now warn whenever a line is longer
than 100 characters and error out on line longer than 9999 which would
never be reached hopefully.
The idea is to be able to ignore the line lenght in 'strict' Jenkins jobs.
Change-Id: I19475a97beda04e4d27d7ce3ee33f4770be26bb4
---
M MediaWiki/ruleset.xml
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Hashar: Verified; Looks good to me, approved
diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml
index 81132bf..1327279 100644
--- a/MediaWiki/ruleset.xml
+++ b/MediaWiki/ruleset.xml
@@ -25,8 +25,10 @@
<rule ref="Generic.Files.LineEndings" />
<rule ref="Generic.Files.LineLength">
<properties>
+ <!-- More than 100 will throw a warning ... -->
<property name="lineLimit" value="100" />
- <property name="absoluteLineLimit" value="120" />
+ <!-- ... but we will most probably never throw an error
-->
+ <property name="absoluteLineLimit" value="9999" />
</properties>
</rule>
<!-- <rule ref="Generic.Files.OneClassPerFile" /> -->
--
To view, visit https://gerrit.wikimedia.org/r/81220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19475a97beda04e4d27d7ce3ee33f4770be26bb4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>
Gerrit-Reviewer: Hashar <has...@free.fr>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
