Hashar has uploaded a new change for review.
https://gerrit.wikimedia.org/r/81220
Change subject: lines longer than 79 will warn (no error)
......................................................................
lines longer than 79 will warn (no error)
Generic.Files.LineLength sniff will now warn whenever a line is longer
than 79 characters and error out on line longer than 9999 which would
never be reached hopefully.
The idea is to be able to ignore the line lenght in 'strict' Jenkins jobs.
Change-Id: I19475a97beda04e4d27d7ce3ee33f4770be26bb4
---
M MediaWiki/ruleset.xml
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer
refs/changes/20/81220/1
diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml
index 81132bf..29bcb46 100644
--- a/MediaWiki/ruleset.xml
+++ b/MediaWiki/ruleset.xml
@@ -25,8 +25,10 @@
<rule ref="Generic.Files.LineEndings" />
<rule ref="Generic.Files.LineLength">
<properties>
- <property name="lineLimit" value="100" />
- <property name="absoluteLineLimit" value="120" />
+ <!-- More than 79 will throw a warning ... -->
+ <property name="lineLimit" value="79" />
+ <!-- ... but we will most probably never throw an error
-->
+ <property name="absoluteLineLimit" value="9999" />
</properties>
</rule>
<!-- <rule ref="Generic.Files.OneClassPerFile" /> -->
--
To view, visit https://gerrit.wikimedia.org/r/81220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19475a97beda04e4d27d7ce3ee33f4770be26bb4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
