Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/300817
Change subject: Add callable doc comments for WANObjectCache
......................................................................
Add callable doc comments for WANObjectCache
Change-Id: I28a705ae12e065dc8a3921e33c873f9a7fbb7490
---
M includes/libs/objectcache/WANObjectCache.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/17/300817/1
diff --git a/includes/libs/objectcache/WANObjectCache.php
b/includes/libs/objectcache/WANObjectCache.php
index 2dc17bf..fd916fe 100644
--- a/includes/libs/objectcache/WANObjectCache.php
+++ b/includes/libs/objectcache/WANObjectCache.php
@@ -759,7 +759,7 @@
* @param array $opts Options map:
* - checkKeys: List of "check" keys. The key at $key will be seen as
invalid when either
* touchCheckKey() or resetCheckKey() is called on any of these
keys.
- * Default: [];
+ * Default: [].
* - lowTTL: Consider pre-emptive updates when the current TTL (sec)
of the key is less than
* this. It becomes more likely over time, becoming a certainty
once the key is expired.
* Default: WANObjectCache::LOW_TTL seconds.
@@ -788,6 +788,7 @@
* however, as this reduces compatibility (due to serialization).
* Default: null.
* @return mixed Value found or written to the key
+ * @note Callable type hints are not used to avoid class-autoloading
*/
final public function getWithSetCallback( $key, $ttl, $callback, array
$opts = [] ) {
$pcTTL = isset( $opts['pcTTL'] ) ? $opts['pcTTL'] :
self::TTL_UNCACHEABLE;
@@ -862,6 +863,7 @@
* - minTime: Treat values older than this UNIX timestamp as not
existing. Default: null.
* @param float &$asOf Cache generation timestamp of returned value
[returned]
* @return mixed
+ * @note Callable type hints are not used to avoid class-autoloading
*/
protected function doGetWithSetCallback( $key, $ttl, $callback, array
$opts, &$asOf = null ) {
$lowTTL = isset( $opts['lowTTL'] ) ? $opts['lowTTL'] : min(
self::LOW_TTL, $ttl );
--
To view, visit https://gerrit.wikimedia.org/r/300817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28a705ae12e065dc8a3921e33c873f9a7fbb7490
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
