Thiemo Mättig (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391200 )

Change subject: Add missing documentation to 
AbstractPrimaryAuthenticationProvider
......................................................................

Add missing documentation to AbstractPrimaryAuthenticationProvider

Change-Id: Ifec6405998758351ae492a88c61f09d609497ee3
---
M includes/auth/AbstractPrimaryAuthenticationProvider.php
1 file changed, 17 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/00/391200/1

diff --git a/includes/auth/AbstractPrimaryAuthenticationProvider.php 
b/includes/auth/AbstractPrimaryAuthenticationProvider.php
index ca947b6..0b3ffb7 100644
--- a/includes/auth/AbstractPrimaryAuthenticationProvider.php
+++ b/includes/auth/AbstractPrimaryAuthenticationProvider.php
@@ -21,6 +21,7 @@
 
 namespace MediaWiki\Auth;
 
+use StatusValue;
 use User;
 
 /**
@@ -76,8 +77,15 @@
                return true;
        }
 
+       /**
+        * @param User $user
+        * @param User $creator
+        * @param AuthenticationRequest[] $reqs
+        *
+        * @return StatusValue
+        */
        public function testForAccountCreation( $user, $creator, array $reqs ) {
-               return \StatusValue::newGood();
+               return StatusValue::newGood();
        }
 
        public function continuePrimaryAccountCreation( $user, $creator, array 
$reqs ) {
@@ -91,8 +99,15 @@
        public function postAccountCreation( $user, $creator, 
AuthenticationResponse $response ) {
        }
 
+       /**
+        * @param User $user
+        * @param bool|string $autocreate
+        * @param array $options
+        *
+        * @return StatusValue
+        */
        public function testUserForCreation( $user, $autocreate, array $options 
= [] ) {
-               return \StatusValue::newGood();
+               return StatusValue::newGood();
        }
 
        public function autoCreatedAccount( $user, $source ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/391200
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifec6405998758351ae492a88c61f09d609497ee3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.kr...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to